bpf: use preempt_disable/enable() to protect bpf_bprintf_buffers nesting #6333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Upstream branch: 026bcf9 |
Author
|
Upstream branch: 026bcf9 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1022157=>bpf-next
branch
from
4c93fc6 to
f5fb66b
Compare
Author
|
Upstream branch: 026bcf9 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1022157=>bpf-next
branch
from
f5fb66b to
7599e49
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
4eb9670 to
e1b05fd
Compare
Author
|
Upstream branch: f1d8c65 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1022157=>bpf-next
branch
from
7599e49 to
77fec86
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
e1b05fd to
b1af442
Compare
Author
|
Upstream branch: 93ce3be |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1022157=>bpf-next
branch
from
77fec86 to
fc73211
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
b1af442 to
67d3dd3
Compare
Author
|
Upstream branch: 93ce3be |
The bpf_bprintf_prepare() and related helpers (bpf_try_get_buffers() / bpf_put_buffers()) rely on a per-CPU counter bpf_bprintf_nest_level to manage nested buffer usage. However, when invoked from different contexts (process, softirq, NMI), the nesting counter can become inconsistent if task migration occurs between CPUs during these operations. This can result in warnings such as: WARNING: CPU: 1 PID: 6145 at kernel/bpf/helpers.c:781 bpf_try_get_buffers kernel/bpf/helpers.c:781 [inline] WARNING: CPU: 1 PID: 6145 at kernel/bpf/helpers.c:781 bpf_bprintf_prepare+0x12cf/0x13a0 kernel/bpf/helpers.c:834 Having only migrate_disable is insufficient here to prevent nesting, hence add preempt_disable()/enable() around buffer acquisition and release. Reported-by: [email protected] Closes: https://lore.kernel.org/all/[email protected]/ Fixes: 4223bf8 ("bpf: Remove preempt_disable in bpf_try_get_buffers") Suggested-by: Yonghong Song <[email protected]> Signed-off-by: Sahil Chandna <[email protected]> Acked-by: Yonghong Song <[email protected]> Reviewed-by: Sebastian Andrzej Siewior <[email protected]>
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1022157=>bpf-next
branch
from
fc73211 to
ab3fc16
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
67d3dd3 to
488318d
Compare
Author
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=1022157 irrelevant now. Closing PR. |
kernel-patches-daemon-bpf-rc
bot
deleted the
series/1022157=>bpf-next
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: bpf: use preempt_disable/enable() to protect bpf_bprintf_buffers nesting
version: 2
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=1022157