Switch to kmalloc_nolock() in BPF local storage #6339
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elements Since commit a96a44a ("bpf: bpf_sk_storage: Fix invalid wait context lockdep report"), {charge,uncharge}_mem are always true when allocating a bpf_local_storage_elem or unlinking a bpf_local_storage_elem from local storage, so drop these arguments. No functional change. Signed-off-by: Amery Hung <[email protected]>
Simplify local storage and selem memory alloc/free paths by switching to kmalloc_nolock unconditionally. While it is okay to call bpf_obj_free_fields() immediately in bpf_selem_free() when reuse_now == true, it is kept only in bpf_selem_free_rcu() to simplify the code. This requires rcu_barrier() to be called unconditionally in bpf_local_storage_map_free() since bpf_obj_free_fields() may also be called from rcu callbacks. In addition, remove the argument, smap, from bpf_selem_free() and rely on SDATA(selem)->smap for bpf_obj_free_fields(). This requires initializing SDATA(selem)->smap earlier during bpf_selem_alloc() as bpf_local_storage_update() can allocate an selem and free it without ever linking it to a map. Finally, clean up and update comments. Note that, we already free selem after an RCU grace period in bpf_local_storage_update() when bpf_local_storage_alloc() failed the cmpxchg since commit c0d63f3 ("bpf: Add bpf_selem_free()"). Signed-off-by: Amery Hung <[email protected]>
Author
|
Upstream branch: 026bcf9 |
Author
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=1022622 expired. Closing PR. |
kernel-patches-daemon-bpf-rc
bot
deleted the
series/1022622=>bpf-next
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: Switch to kmalloc_nolock() in BPF local storage
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=1022622