bpf: Check skb->transport_header is set in bpf_skb_check_mtu #6340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Upstream branch: 3249e8a |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
4eb9670 to
e1b05fd
Compare
Author
|
Upstream branch: f1d8c65 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1022702=>bpf-next
branch
from
51ad6bb to
b029497
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
e1b05fd to
b1af442
Compare
Author
|
Upstream branch: 93ce3be |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1022702=>bpf-next
branch
from
b029497 to
39dad8b
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
b1af442 to
67d3dd3
Compare
Author
|
Upstream branch: 93ce3be |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1022702=>bpf-next
branch
from
39dad8b to
3a7dd20
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
67d3dd3 to
488318d
Compare
Author
|
Upstream branch: c1da3df |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1022702=>bpf-next
branch
from
3a7dd20 to
7bfcc49
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
488318d to
728ac5f
Compare
Author
|
Upstream branch: fea3f5e |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1022702=>bpf-next
branch
from
7bfcc49 to
061c98a
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
728ac5f to
4fcc7e1
Compare
Author
|
Upstream branch: 63066b7 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1022702=>bpf-next
branch
from
061c98a to
8c77721
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
4fcc7e1 to
1aeb398
Compare
Author
|
Upstream branch: c133390 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1022702=>bpf-next
branch
from
8c77721 to
5ceb706
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
1aeb398 to
f68d848
Compare
Author
|
Upstream branch: ef2c0b2 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1022702=>bpf-next
branch
from
5ceb706 to
33a90d9
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
f68d848 to
3fd24de
Compare
Author
|
Upstream branch: a4d31f4 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1022702=>bpf-next
branch
from
33a90d9 to
276477f
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
3fd24de to
22f76ea
Compare
The bpf_skb_check_mtu helper needs to use skb->transport_header when the BPF_MTU_CHK_SEGS flag is used: bpf_skb_check_mtu(skb, ifindex, &mtu_len, 0, BPF_MTU_CHK_SEGS) The transport_header is not always set. There is a WARN_ON_ONCE report when CONFIG_DEBUG_NET is enabled + skb->gso_size is set + bpf_prog_test_run is used: WARNING: CPU: 1 PID: 2216 at ./include/linux/skbuff.h:3071 skb_gso_validate_network_len bpf_skb_check_mtu bpf_prog_3920e25740a41171_tc_chk_segs_flag # A test in the next patch bpf_test_run bpf_prog_test_run_skb For a normal ingress skb (not test_run), skb_reset_transport_header is performed but there is plan to avoid setting it as described in commit 2170a1f ("net: no longer reset transport_header in __netif_receive_skb_core()"). This patch fixes the bpf helper by checking skb_transport_header_was_set(). The check is done just before skb->transport_header is used, to avoid breaking the existing bpf prog. The WARN_ON_ONCE is limited to bpf_prog_test_run, so targeting bpf-next. Fixes: 34b2021 ("bpf: Add BPF-helper for MTU checking") Cc: Jesper Dangaard Brouer <[email protected]> Reported-by: Kaiyan Mei <[email protected]> Reported-by: Yinhao Hu <[email protected]> Signed-off-by: Martin KaFai Lau <[email protected]>
Author
|
Upstream branch: 4f7bc83 |
…t_header is not set Add a test to check that bpf_skb_check_mtu(BPF_MTU_CHK_SEGS) is rejected (-EINVAL) if skb->transport_header is not set. The test needs to lower the MTU of the loopback device. Thus, take this opportunity to run the test in a netns by adding "ns_" to the test name. The "serial_" prefix can then be removed. Signed-off-by: Martin KaFai Lau <[email protected]>
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1022702=>bpf-next
branch
from
276477f to
ad86057
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
22f76ea to
d766c2f
Compare
Author
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=1022702 irrelevant now. Closing PR. |
kernel-patches-daemon-bpf-rc
bot
deleted the
series/1022702=>bpf-next
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: bpf: Check skb->transport_header is set in bpf_skb_check_mtu
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=1022702