Skip to content

Conversation

@kernel-patches-daemon-bpf-rc
Copy link

Pull request for series with
subject: bpf: verifier improvement in 32bit shift sign extension pattern
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=1025754

@kernel-patches-daemon-bpf-rc
Copy link
Author

Upstream branch: d6ec090
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1025754
version: 1

@kernel-patches-daemon-bpf-rc
Copy link
Author

Upstream branch: d088da9
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1025754
version: 1

@kernel-patches-daemon-bpf-rc
Copy link
Author

Upstream branch: e0940c6
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1025754
version: 1

@kernel-patches-daemon-bpf-rc
Copy link
Author

Upstream branch: 792f258
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1025754
version: 1

@kernel-patches-daemon-bpf-rc
Copy link
Author

Upstream branch: 792f258
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1025754
version: 1

@kernel-patches-daemon-bpf-rc
Copy link
Author

Upstream branch: 878ee3c
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1025754
version: 1

@kernel-patches-daemon-bpf-rc
Copy link
Author

Upstream branch: ae24fc8
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1025754
version: 1

@kernel-patches-daemon-bpf-rc
Copy link
Author

Upstream branch: b7f7d76
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1025754
version: 1

@kernel-patches-daemon-bpf-rc
Copy link
Author

Upstream branch: 4dd3a48
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1025754
version: 1

@kernel-patches-daemon-bpf-rc
Copy link
Author

Upstream branch: 8f7cf30
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1025754
version: 1

This patch improves the verifier to correctly compute bounds for sign
extension compiler pattern composed of left shift by 32bits followed by
a sign right shift by 32bits.
Pattern in the verifier was limitted to positive value bounds and would
reset bound computation for negative values.
New code allows both positive and negative values for sign extension
without compromising bound computation and verifier to pass.

This change is required by GCC which generate such pattern, and was
detected in the context of systemd, as described in the following GCC
bugzilla:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=119731

Three new tests were added in verifier_subreg.c.

Signed-off-by: Cupertino Miranda  <[email protected]>
Signed-off-by: Andrew Pinski  <[email protected]>
Cc: David Faust <[email protected]>
Cc: Jose Marchesi <[email protected]>
Cc: Elena Zannoni <[email protected]>
Acked-by: Eduard Zingerman <[email protected]>
@kernel-patches-daemon-bpf-rc
Copy link
Author

Upstream branch: c427320
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1025754
version: 1

@kernel-patches-daemon-bpf-rc
Copy link
Author

At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=1025754 expired. Closing PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants