-
Notifications
You must be signed in to change notification settings - Fork 5
libbpf: Add debug messaging in dedup equivalence/identity matching #6404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libbpf: Add debug messaging in dedup equivalence/identity matching #6404
Conversation
|
Upstream branch: e0940c6 |
623bab9 to
fe03c14
Compare
|
Upstream branch: 792f258 |
30488bb to
80a39a5
Compare
|
Upstream branch: 792f258 |
80a39a5 to
6ed0019
Compare
fe03c14 to
65bfb85
Compare
|
Upstream branch: 878ee3c |
6ed0019 to
3c1f210
Compare
65bfb85 to
b1f8b58
Compare
|
Upstream branch: ae24fc8 |
3c1f210 to
6fd2339
Compare
b1f8b58 to
8f7081b
Compare
|
Upstream branch: b7f7d76 |
6fd2339 to
8a1e7da
Compare
8f7081b to
c347688
Compare
|
Upstream branch: 4dd3a48 |
8a1e7da to
02f2490
Compare
c347688 to
fb42a92
Compare
|
Upstream branch: 8f7cf30 |
02f2490 to
c333c41
Compare
fb42a92 to
3282beb
Compare
|
Upstream branch: c427320 |
c333c41 to
d03d8f7
Compare
3282beb to
067f842
Compare
|
Upstream branch: fad8040 |
d03d8f7 to
8e113e3
Compare
067f842 to
3bd2c43
Compare
|
Upstream branch: acf8726 |
8e113e3 to
ed83e74
Compare
3bd2c43 to
71c4be1
Compare
|
Upstream branch: 4617b30 |
ed83e74 to
a770a38
Compare
71c4be1 to
9b3817c
Compare
|
Upstream branch: 590699d |
a770a38 to
6293121
Compare
9b3817c to
90dfd48
Compare
|
Upstream branch: f2cb066 |
6293121 to
1859854
Compare
90dfd48 to
1559a3a
Compare
We have seen a number of issues like [1]; failures to deduplicate key kernel data structures like task_struct. These are often hard to debug from pahole even with verbose output, especially when identity/equivalence checks fail deep in a nested struct comparison. Here we add debug messages of the form libbpf: struct 'task_struct' (size 2560 vlen 194) appears equivalent but differs for 23-indexed cand/canon member 'sched_class'/'sched_class': 0 These will be emitted during dedup from pahole when --verbose/-V is specified. This greatly helps identify exactly where dedup failures are experienced. [1] https://lore.kernel.org/bpf/[email protected]/ Signed-off-by: Alan Maguire <[email protected]> Acked-by: Eduard Zingerman <[email protected]>
|
Upstream branch: 8c868a3 |
1859854 to
39d80a4
Compare
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=1026051 expired. Closing PR. |
Pull request for series with
subject: libbpf: Add debug messaging in dedup equivalence/identity matching
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=1026051