Skip to content

Conversation

@kernel-patches-daemon-bpf-rc
Copy link

Pull request for series with
subject: libbpf: Add debug messaging in dedup equivalence/identity matching
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=1026051

@kernel-patches-daemon-bpf-rc
Copy link
Author

Upstream branch: e0940c6
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1026051
version: 1

@kernel-patches-daemon-bpf-rc
Copy link
Author

Upstream branch: 792f258
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1026051
version: 1

@kernel-patches-daemon-bpf-rc
Copy link
Author

Upstream branch: 792f258
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1026051
version: 1

@kernel-patches-daemon-bpf-rc
Copy link
Author

Upstream branch: 878ee3c
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1026051
version: 1

@kernel-patches-daemon-bpf-rc
Copy link
Author

Upstream branch: ae24fc8
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1026051
version: 1

@kernel-patches-daemon-bpf-rc
Copy link
Author

Upstream branch: b7f7d76
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1026051
version: 1

@kernel-patches-daemon-bpf-rc
Copy link
Author

Upstream branch: 4dd3a48
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1026051
version: 1

@kernel-patches-daemon-bpf-rc
Copy link
Author

Upstream branch: 8f7cf30
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1026051
version: 1

@kernel-patches-daemon-bpf-rc
Copy link
Author

Upstream branch: c427320
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1026051
version: 1

@kernel-patches-daemon-bpf-rc
Copy link
Author

Upstream branch: fad8040
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1026051
version: 1

@kernel-patches-daemon-bpf-rc
Copy link
Author

Upstream branch: acf8726
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1026051
version: 1

@kernel-patches-daemon-bpf-rc
Copy link
Author

Upstream branch: 4617b30
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1026051
version: 1

@kernel-patches-daemon-bpf-rc
Copy link
Author

Upstream branch: 590699d
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1026051
version: 1

@kernel-patches-daemon-bpf-rc
Copy link
Author

Upstream branch: f2cb066
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1026051
version: 1

We have seen a number of issues like [1]; failures to deduplicate
key kernel data structures like task_struct.  These are often hard
to debug from pahole even with verbose output, especially when
identity/equivalence checks fail deep in a nested struct comparison.

Here we add debug messages of the form

libbpf: struct 'task_struct' (size 2560 vlen 194) appears equivalent but differs for 23-indexed cand/canon member 'sched_class'/'sched_class': 0

These will be emitted during dedup from pahole when --verbose/-V
is specified.  This greatly helps identify exactly where dedup
failures are experienced.

[1] https://lore.kernel.org/bpf/[email protected]/

Signed-off-by: Alan Maguire <[email protected]>
Acked-by: Eduard Zingerman <[email protected]>
@kernel-patches-daemon-bpf-rc
Copy link
Author

Upstream branch: 8c868a3
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1026051
version: 1

@kernel-patches-daemon-bpf-rc
Copy link
Author

At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=1026051 expired. Closing PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants