libbpf: Add debug messaging in dedup equivalence/identity matching #6455
+29
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Upstream branch: ff34657 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
52f5a27 to
037d2fc
Compare
Author
|
Upstream branch: ff34657 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1030217=>bpf-next
branch
from
e8226a2 to
e0b8cfe
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
037d2fc to
8f722b4
Compare
Author
|
Upstream branch: 8f7aa3d |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1030217=>bpf-next
branch
from
e0b8cfe to
a70fcdd
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
8f722b4 to
03e2ed2
Compare
Author
|
Upstream branch: 835a507 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1030217=>bpf-next
branch
from
a70fcdd to
4cbf57b
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
03e2ed2 to
3ea267d
Compare
Author
|
Upstream branch: 835a507 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1030217=>bpf-next
branch
from
4cbf57b to
f4269c4
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
3ea267d to
6d4eb64
Compare
We have seen a number of issues like [1]; failures to deduplicate key kernel data structures like task_struct. These are often hard to debug from pahole even with verbose output, especially when identity/equivalence checks fail deep in a nested struct comparison. Here we add debug messages of the form libbpf: STRUCT 'task_struct' size=2560 vlen=194 cand_id[54222] canon_id[102820] shallow-equal but not equiv for field#23 'sched_class': 0 These will be emitted during dedup from pahole when --verbose/-V is specified. This greatly helps identify exactly where dedup failures are experienced. [1] https://lore.kernel.org/bpf/[email protected]/ Changes since v1: - updated debug messages to refer to shallow-equal, added ids (Andrii) Signed-off-by: Alan Maguire <[email protected]>
Author
|
Upstream branch: 835a507 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1030217=>bpf-next
branch
from
f4269c4 to
8546e36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: libbpf: Add debug messaging in dedup equivalence/identity matching
version: 2
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=1030217