selftests/bpf: Fix task_local_data failure with 64K page #10813
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Upstream branch: a32ae26 |
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
5f0eb13 to
e1cc553
Compare
Author
|
Upstream branch: 82f3b14 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1046027=>bpf-next
branch
from
7a9078f to
f06b3a5
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
e1cc553 to
403c46b
Compare
Author
|
Upstream branch: c99225b |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1046027=>bpf-next
branch
from
f06b3a5 to
931cb28
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
403c46b to
53953d6
Compare
Author
|
Upstream branch: 82f3b14 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1046027=>bpf-next
branch
from
931cb28 to
4fd99d1
Compare
added 2 commits
January 24, 2026 09:10
On arm64 systems with 64K pages, the selftest task_local_data has the following failures: ... test_task_local_data_basic:PASS:tld_create_key 0 nsec test_task_local_data_basic:FAIL:tld_create_key unexpected tld_create_key: actual 0 != expected -28 ... test_task_local_data_basic_thread:PASS:run task_main 0 nsec test_task_local_data_basic_thread:FAIL:task_main retval unexpected error: 2 (errno 0) test_task_local_data_basic_thread:FAIL:tld_get_data value0 unexpected tld_get_data value0: actual 0 != expected 6268 ... #447/1 task_local_data/task_local_data_basic:FAIL ... #447/2 task_local_data/task_local_data_race:FAIL #447 task_local_data:FAIL When TLD_DYN_DATA_SIZE is 64K page size, for struct tld_meta_u { _Atomic __u8 cnt; __u16 size; struct tld_metadata metadata[]; }; field 'cnt' would overflow. For example, for 4K page, 'cnt' will be 4096/64 = 64. But for 64K page, 'cnt' will be 65536/64 = 1024 and 'cnt' is not enough for 1024. To accommodate 64K page, '_Atomic __u8 cnt' becomes '_Atomic __u16 cnt'. A few other places are adjusted accordingly. In test_task_local_data.c, the value for TLD_DYN_DATA_SIZE is changed from 4096 to (getpagesize() - 8) since the maximum buffer size for TLD_DYN_DATA_SIZE is (getpagesize() - 8). Reviewed-by: Alan Maguire <[email protected]> Tested-by: Alan Maguire <[email protected]> Cc: Amery Hung <[email protected]> Signed-off-by: Yonghong Song <[email protected]> Acked-by: Amery Hung <[email protected]>
If the argument 'pull_len' of run_test() is 'PULL_MAX' or 'PULL_MAX | PULL_PLUS_ONE', the eventual pull_len size will close to the page size. On arm64 systems with 64K pages, the pull_len size will be close to 64K. But the existing buffer will be close to 9000 which is not enough to pull. For those failed run_tests(), make buff size to pg_sz + (pg_sz / 2) This way, there will be enough buffer space to pull regardless of page size. Tested-by: Alan Maguire <[email protected]> Cc: Amery Hung <[email protected]> Signed-off-by: Yonghong Song <[email protected]> Acked-by: Amery Hung <[email protected]>
Author
|
Upstream branch: 82f3b14 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1046027=>bpf-next
branch
from
4fd99d1 to
278dcb8
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
53953d6 to
1682daf
Compare
Author
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=1046027 irrelevant now. Closing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: selftests/bpf: Fix task_local_data failure with 64K page
version: 4
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=1046027