Separate tests that need error injection#11006
Closed
kernel-patches-daemon-bpf[bot] wants to merge 3 commits intobpf-next_basefrom
Closed
Separate tests that need error injection#11006kernel-patches-daemon-bpf[bot] wants to merge 3 commits intobpf-next_basefrom
kernel-patches-daemon-bpf[bot] wants to merge 3 commits intobpf-next_basefrom
Conversation
The test verifies attachment to various hooks in a kernel module, however, everything is flattened into a single test. When running the test on a kernel which doesn't support some of the hooks, it is impossible to skip them selectively. Isolate each BPF program into a separate subtest. This is done by disabling auto-loading of programs and loading and testing each program separately. Signed-off-by: Viktor Malik <vmalik@redhat.com>
Split the test into two subtests: one for checking bpf_probe_read* of a vsyscall page from a non-sleepable probe and one for checking bpf_copy_from_user* of a vsyscall page from a sleepable probe. The split is useful for running the test on kernels which do not support sleepable fentry programs to allow skipping just a part of the test. Signed-off-by: Viktor Malik <vmalik@redhat.com>
The test_lsm/lsm_basic test contains a test attaching to a sleepable fentry, which doesn't logically fit into the LSM test suite. In addition, it makes the entire test fail on kernels which do not support sleepable fentry programs. Factor out the sleepable fentry part into a new test fentry_sleepable. Signed-off-by: Viktor Malik <vmalik@redhat.com>
Author
|
Upstream branch: db975de |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: Separate tests that need error injection
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=1052713