Skip to content

bpf: Bump maximum runtime call stack depth to 16#11015

Closed
kernel-patches-daemon-bpf[bot] wants to merge 1 commit intobpf-next_basefrom
series/1052899=>bpf-next
Closed

bpf: Bump maximum runtime call stack depth to 16#11015
kernel-patches-daemon-bpf[bot] wants to merge 1 commit intobpf-next_basefrom
series/1052899=>bpf-next

Conversation

@kernel-patches-daemon-bpf
Copy link

Pull request for series with
subject: bpf: Bump maximum runtime call stack depth to 16
version: 2
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=1052899

@kernel-patches-daemon-bpf
Copy link
Author

Upstream branch: a9aabb3
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1052899
version: 2

@kernel-patches-daemon-bpf
Copy link
Author

Upstream branch: dc855b7
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1052899
version: 2

@kernel-patches-daemon-bpf
Copy link
Author

Upstream branch: dc855b7
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1052899
version: 2

@kernel-patches-daemon-bpf
Copy link
Author

Upstream branch: 4475cda
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1052899
version: 2

@kernel-patches-daemon-bpf
Copy link
Author

Upstream branch: 19de32d
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1052899
version: 2

@kernel-patches-daemon-bpf
Copy link
Author

Upstream branch: a86c608
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1052899
version: 2

@kernel-patches-daemon-bpf
Copy link
Author

Upstream branch: a86c608
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1052899
version: 2

@kernel-patches-daemon-bpf
Copy link
Author

Upstream branch: a86c608
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1052899
version: 2

@kernel-patches-daemon-bpf
Copy link
Author

Upstream branch: 561085f
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1052899
version: 2

@kernel-patches-daemon-bpf
Copy link
Author

Upstream branch: f632de6
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1052899
version: 2

@kernel-patches-daemon-bpf
Copy link
Author

Upstream branch: 4c51f90
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1052899
version: 2

The BPF verifier currently limits the maximum runtime call stack to
8 frames. Larger BPF programs like sched-ext schedulers routinely
fail verification because they exceed this limit, even as they use
very little actual stack space for each frame.

Bump the maximum runtime call stack depth to 16 stack frames. Also
adjust selftests that assume the max runtime call stack depth is 8.

This patch does not change the verification time limit of 8 stack
frames. Static functions that are inlined for verification purposes
still only go 8 frames deep to avoid changing the verifier's internal
data structures used for verification. These data structures only
support holding information on up to 8 stack frames.

Global functions are each verified in isolation, so the old 8 stack
frame limit now only applies to call stacks composed entirely of
static function calls.

This patch also does not adjust the actual maximum stack size of 512.

CHANGELOG
=========

v1 -> v2 (https://lore.kernel.org/bpf/DG510ANGXEZH.BJ9EMMKHP5WT@etsalapatis.com)

- Adjust patch to only increase the runtime stack depth, leaving the
verification-time stack depth unchanged (Alexei)

Signed-off-by: Emil Tsalapatis <emil@etsalapatis.com>
@kernel-patches-daemon-bpf
Copy link
Author

At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=1052899 expired. Closing PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant