Skip to content

bpf: fix selftest/xsk single test selection#11078

Closed
kernel-patches-daemon-bpf[bot] wants to merge 1 commit intobpf_basefrom
series/1054787=>bpf
Closed

bpf: fix selftest/xsk single test selection#11078
kernel-patches-daemon-bpf[bot] wants to merge 1 commit intobpf_basefrom
series/1054787=>bpf

Conversation

@kernel-patches-daemon-bpf
Copy link

@kernel-patches-daemon-bpf kernel-patches-daemon-bpf bot commented Feb 17, 2026

Pull request for series with
subject: bpf: fix selftest/xsk single test selection
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=1054787

@kernel-patches-daemon-bpf
Copy link
Author

kernel-patches-daemon-bpf bot commented Feb 17, 2026

Upstream branch: 886bf92
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1054787
version: 1

@kernel-patches-review-bot
Copy link

kernel-patches-review-bot bot commented Feb 17, 2026 

commit c0f2243e68f6d072cd4033f573b3b0e1b3ae33ee
Author: Mahdi Faramarzpour <mahdifrmx@gmail.com>

bpf: fix selftest/xsk single test selection

Fixes the integer parsing of the -t option in xskxceiver by adding an
endptr check to strtol(), since errno alone is not guaranteed to
indicate conversion failure on all systems.

Fixes: 146e30554a53 ("selftests/xsk: add option to run single test")

> Signd-off-by: Mahdi Faramarzpour <mahdifrmx@gmail.com>

Should this be "Signed-off-by"?

AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md

In-Reply-To-Subject: bpf: fix selftest/xsk single test selection
CI run summary: https://github.com/kernel-patches/bpf/actions/runs/22090844124

AI-authorship-score: low
AI-authorship-explanation: Natural writing style with human uncertainty markers and specific manpage citation suggest human authorship; the Signed-off-by typo is consistent with human error.
issues-found: 1
issue-severity-score: low
issue-severity-explanation: Misspelled Signed-off-by tag (Signd-off-by) breaks the Developer Certificate of Origin chain and automated tooling recognition.

@kernel-patches-daemon-bpf
Copy link
Author

kernel-patches-daemon-bpf bot commented Feb 17, 2026

Forwarding comment 3913055491 via email
In-Reply-To: 20260217080326.50564-1-mahdifrmz@gmail.com
Patch: https://patchwork.kernel.org/project/netdevbpf/patch/20260217080326.50564-1-mahdifrmz@gmail.com/

@kernel-patches-daemon-bpf
Copy link
Author

kernel-patches-daemon-bpf bot commented Feb 17, 2026

Upstream branch: b0b1a85
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1054787
version: 1

@kernel-patches-daemon-bpf
Copy link
Author

kernel-patches-daemon-bpf bot commented Feb 17, 2026

Upstream branch: 593fffb
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1054787
version: 1

@kernel-patches-daemon-bpf
Copy link
Author

kernel-patches-daemon-bpf bot commented Feb 18, 2026

Upstream branch: 3b39d73
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1054787
version: 1

bpf: fix selftest/xsk single test selection
1b525a7 
This commit fixes the integer parsing of -t option. The cli parser
only relies on errno to detect parsing errors. The manpage for
strtol (https://man7.org/linux/man-pages/man3/strtol.3.html)
states that the said function "MAY" set errno to EINVAL in case the
conversion fails. Currently on some systems, this leads to a silent
failure with return value not being exactly documented in the
manpages (probably zero). The reliable way to validate the input is
to check whether the endptr has been bumped all the way to the end
of the string or not.

Signd-off-by: Mahdi Faramarzpour <mahdifrmx@gmail.com>
Fixes: 146e305 ("selftests/xsk: add option to run single test")
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bpf new V1-ci-fail V1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

0 participants

Comments