bpf: cpumap: add missing XDP_ABORTED handling in xdp prog runner#11096
Open
kernel-patches-daemon-bpf[bot] wants to merge 1 commit intobpf-next_basefrom
Open
bpf: cpumap: add missing XDP_ABORTED handling in xdp prog runner#11096kernel-patches-daemon-bpf[bot] wants to merge 1 commit intobpf-next_basefrom
kernel-patches-daemon-bpf[bot] wants to merge 1 commit intobpf-next_basefrom
Conversation
Author
|
Upstream branch: 4c51f90 |
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
2650068 to
291a805
Compare
Author
|
Upstream branch: 4c51f90 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1055078=>bpf-next
branch
from
990037c to
1ac5c70
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
291a805 to
44a817a
Compare
cpu_map_bpf_prog_run_xdp() handles XDP_PASS, XDP_REDIRECT, and XDP_DROP but is missing an XDP_ABORTED case. Without it, XDP_ABORTED falls into the default case which logs a misleading "invalid XDP action" warning instead of tracing the abort via trace_xdp_exception(). Add the missing XDP_ABORTED case with trace_xdp_exception(), matching the handling already present in the skb path (cpu_map_bpf_prog_run_skb), devmap (dev_map_bpf_prog_run), and the generic XDP path (do_xdp_generic). Also pass xdpf->dev_rx instead of NULL to bpf_warn_invalid_xdp_action() in the default case, so the warning includes the actual device name. This aligns with the generic XDP path in net/core/dev.c which already passes the real device. Signed-off-by: Anand Kumar Shaw <anandkrshawheritage@gmail.com>
Author
|
Upstream branch: 0158268 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1055078=>bpf-next
branch
from
1ac5c70 to
67637b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: bpf: cpumap: add missing XDP_ABORTED handling in xdp prog runner
version: 3
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=1055078