Skip to content

selftests/bpf: add BPF program dump in veristat #9445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: bpf-next_base
Choose a base branch
from
+43 −1
Draft

selftests/bpf: add BPF program dump in veristat #9445

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 43 additions & 1 deletion tools/testing/selftests/bpf/veristat.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,12 @@ struct var_preset {
bool applied;
};

enum dump_mode {
NO_DUMP = 0,
XLATED,
JITED,
};

static struct env {
char **filenames;
int filename_cnt;
Expand Down Expand Up @@ -227,6 +233,7 @@ static struct env {
char orig_cgroup[PATH_MAX];
char stat_cgroup[PATH_MAX];
int memory_peak_fd;
enum dump_mode dump_mode;
} env;

static int libbpf_print_fn(enum libbpf_print_level level, const char *format, va_list args)
Expand Down Expand Up @@ -295,6 +302,7 @@ static const struct argp_option opts[] = {
"Force BPF verifier failure on register invariant violation (BPF_F_TEST_REG_INVARIANTS program flag)" },
{ "top-src-lines", 'S', "N", 0, "Emit N most frequent source code lines" },
{ "set-global-vars", 'G', "GLOBAL", 0, "Set global variables provided in the expression, for example \"var1 = 1\"" },
{ "dump", 'p', "DUMP", 0, "Print BPF program dump" },
{},
};

Expand Down Expand Up @@ -427,6 +435,16 @@ static error_t parse_arg(int key, char *arg, struct argp_state *state)
return err;
}
break;
case 'p':
if (strcmp(arg, "jited") == 0) {
env.dump_mode = JITED;
} else if (strcmp(arg, "xlated") == 0) {
env.dump_mode = XLATED;
} else {
fprintf(stderr, "Unrecognized dump mode '%s'\n", arg);
return -EINVAL;
}
break;
default:
return ARGP_ERR_UNKNOWN;
}
Expand Down Expand Up @@ -1554,6 +1572,27 @@ static int parse_rvalue(const char *val, struct rvalue *rvalue)
return 0;
}

static void dump(int prog_fd)
{
char command[512];
char buf[1024];
FILE *fp;

snprintf(command, sizeof(command), "bpftool prog dump %s id %d",
env.dump_mode == JITED ? "jited" : "xlated", prog_fd);
fp = popen(command, "r");
if (!fp) {
fprintf(stderr, "Can't run bpftool\n");
return;
}

while (fgets(buf, sizeof(buf), fp)) {
printf("%s", buf);
}

pclose(fp);
}

static int process_prog(const char *filename, struct bpf_object *obj, struct bpf_program *prog)
{
const char *base_filename = basename(strdupa(filename));
Expand Down Expand Up @@ -1630,8 +1669,11 @@ static int process_prog(const char *filename, struct bpf_object *obj, struct bpf

memset(&info, 0, info_len);
fd = bpf_program__fd(prog);
if (fd > 0 && bpf_prog_get_info_by_fd(fd, &info, &info_len) == 0)
if (fd > 0 && bpf_prog_get_info_by_fd(fd, &info, &info_len) == 0) {
stats->stats[JITED_SIZE] = info.jited_prog_len;
if (env.dump_mode != NO_DUMP)
dump(info.id);
}

parse_verif_log(buf, buf_sz, stats);

Expand Down
Loading