xsk: fix immature cq descriptor production #9476
Closed
+135
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![kernel-patches-daemon-bpf[bot]](https://avatars.githubusercontent.com/u/70728002?s=60&v=4){kind=small}
|
Upstream branch: 8f5ae30 |
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf_base
branch
from
4755b1f to
0b17fdf
Compare
|
Upstream branch: 7572a47 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/991156=>bpf
branch
from
2d5dfa3 to
f3fdd94
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf_base
branch
from
0b17fdf to
7246b0a
Compare
Eryk reported an issue that I have put under Closes: tag, related to umem addrs being prematurely produced onto pool's completion queue. Let us make the skb's destructor responsible for producing all addrs that given skb used. Introduce struct xsk_addrs which will carry descriptor count with array of addresses taken from processed descriptors that will be carried via skb_shared_info::destructor_arg. This way we can refer to it within xsk_destruct_skb(). In order to mitigate the overhead that will be coming from memory allocations, let us introduce kmem_cache of xsk_addrs, but be smart about scalability, as assigning unique cache per each socket might be expensive. Store kmem_cache as percpu variables with embedded refcounting and let the xsk code index it by queue id. In case when a NIC#0 already runs copy mode xsk socket on queue #10 and user starts a socket on <NIC#1,qid#10> tuple, the kmem_cache is reused. Keep the pointer to kmem_cache in xdp_sock to avoid accessing bss in data path. Commit from fixes tag introduced the buggy behavior, it was not broken from day 1, but rather when xsk multi-buffer got introduced. Fixes: b7f72a3 ("xsk: introduce wrappers and helpers for supporting multi-buffer in Tx path") Reported-by: Eryk Kubanski <[email protected]> Closes: https://lore.kernel.org/netdev/[email protected]/ Acked-by: Magnus Karlsson <[email protected]> Signed-off-by: Maciej Fijalkowski <[email protected]>
|
Upstream branch: e4414b0 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/991156=>bpf
branch
from
f3fdd94 to
35594b5
Compare
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=991156 expired. Closing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: xsk: fix immature cq descriptor production
version: 4
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=991156