branch_worker: PR comments pre-processing #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The format of PR comments (which is github-style markdown) may not be suitable for plain-text email responses, depending on the use-case. Implement a mechanism for pre-processing the contents of PR comments before forwarding them with email. The function transforming the content string must be a method of BranchWorker class, and then its name can be specified (or not) in the pr_comments_forwarding of the KPD config. If pre-processing function is not specified, couldn't be found or fails, the comment text remains unchanged. Signed-off-by: Ihor Solodrai <[email protected]>
eddyz87
reviewed
Oct 30, 2025
| return comment_body | ||
|
|
||
| maybe_func = getattr(self, func_name, None) | ||
| if not callable(maybe_func): |
There was a problem hiding this comment.
Should this be a warning? For is not None case.
There was a problem hiding this comment.
I don't think error logging is necessary here.
If pre-processing isn't working it'll be immediately noticeable in the emails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The format of PR comments (which is github-style markdown) may not be suitable for plain-text email responses, depending on the use-case.
Implement a mechanism for pre-processing the contents of PR comments before forwarding them with email.
The function transforming the content string must be a method of BranchWorker class, and then its name can be specified (or not) in the pr_comments_forwarding of the KPD config.
If pre-processing function is not specified, couldn't be found or fails, the comment text remains unchanged.