Fixes in github_sync and other updates #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to run the test from an arbitrary working directory. Signed-off-by: Ihor Solodrai <[email protected]>
Skip branches for which branch name was _not_ parsed successfully. This bug was introduced in 462b933 Signed-off-by: Ihor Solodrai <[email protected]>
parse_pr_ref assumed well formed branch names, which in some cases
leads to a crash on attempt to extract int series_id.
For example "some/branch" would call int("branch").
It turns out that it also matter for "not relevant" branches, because
when doing cleanup KPD examines all PRs.
Add unit tests for parse_pr_ref() to make sure it does not crash.
Signed-off-by: Ihor Solodrai <[email protected]>
dependabot reported a vulnerability CVE-2024-12797 fixed in 44.0.1 Signed-off-by: Ihor Solodrai <[email protected]>
3.9 is EOL in October 2025 [1]. Also match statement was introduced in 3.10, and it is used in the tests. [1] https://peps.python.org/pep-0596/ Signed-off-by: Ihor Solodrai <[email protected]>
Code formatter: https://github.com/psf/black Signed-off-by: Ihor Solodrai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two bugs introduced in #4, and discovered after deployment.
Also minimum Python is bumped to 3.10
See commits for more details.