veristat: use more strict restore key when fetching the baseline#372
Merged
veristat: use more strict restore key when fetching the baseline#372
Conversation
There were CI failures caused by inappropriate cache restore, when bpf-next baseline was used for patch series against bpf-net. This happened because github cleaned up bpf-net baseline from the cache, and bpf-next baseline matched baseline_name prefix. To avoid such collisions use `<base_branch>-<name>*` as the effective restore key. This is achieved by providing a fake exact key with trailing hyphen (which is always a miss), and relying on actions/cache matching a prefix from restore-keys list [1]. And the only restore-key we set is `<base_branch>-<name>`. [1] https://github.com/actions/cache#creating-a-cache-key Signed-off-by: Ihor Solodrai <isolodrai@meta.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were CI failures caused by inappropriate cache restore, when bpf-next baseline was used for patch series against bpf-net. This happened because github cleaned up bpf-net baseline from the cache, and bpf-next baseline matched baseline_name prefix.
To avoid such collisions use
<base_branch>-<name>*as the effective restore key. This is achieved by providing a fake exact key with trailing hyphen (which is always a miss), and relying on actions/cache matching a prefix from restore-keys list [1]. And the only restore-key we set is<base_branch>-<name>.[1] https://github.com/actions/cache#creating-a-cache-key