Skip to content

Call patch invoke on control + c #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hiroTamada merged 3 commits into from
Sep 22, 2025
Merged

Call patch invoke on control + c #15

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
98b3155
Call patch invoke on control + c
hiroTamada Sep 19, 2025
327e337
Remove unnecessary changes
hiroTamada Sep 19, 2025
1f86286
invoke: mark invocation failed on cancel
hiroTamada Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions cmd/invoke.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,16 +92,23 @@ func runInvoke(cmd *cobra.Command, args []string) error {
return nil
}

// this is a little indirect but we try to fail out of the invocation by deleting the
// underlying browser sessions
// On cancel, mark the invocation as failed via the update endpoint
once := sync.Once{}
onCancel(cmd.Context(), func() {
once.Do(func() {
cleanupStarted.Store(true)
defer close(cleanupDone)
pterm.Warning.Println("Invocation cancelled...cleaning up...")
if err := client.Invocations.DeleteBrowsers(context.Background(), resp.ID, option.WithRequestTimeout(30*time.Second)); err != nil {
pterm.Error.Printf("Failed to cancel invocation: %v\n", err)
if _, err := client.Invocations.Update(
context.Background(),
resp.ID,
kernel.InvocationUpdateParams{
Status: kernel.InvocationUpdateParamsStatusFailed,
Output: kernel.Opt(`{"error":"Invocation cancelled by user"}`),
},
option.WithRequestTimeout(30*time.Second),
); err != nil {
pterm.Error.Printf("Failed to mark invocation as failed: %v\n", err)
}
})
})
Expand Down