Skip to content

refactor(root): extract auth exemption logic #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
masnwilliams merged 1 commit into from
Aug 20, 2025
Merged

refactor(root): extract auth exemption logic #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions cmd/root.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,20 @@ func getKernelClient(cmd *cobra.Command) kernel.Client {
return cmd.Context().Value(KernelClientKey).(kernel.Client)
}

// isAuthExempt returns true if the command or any of its parents should skip auth.
func isAuthExempt(cmd *cobra.Command) bool {
for c := cmd; c != nil; c = c.Parent() {
if c == rootCmd {
return true
}
switch c.Name() {
case "login", "logout", "auth", "help", "completion":
return true
}
}
return false
}

func init() {
rootCmd.PersistentFlags().BoolP("version", "v", false, "Print the CLI version")
rootCmd.PersistentFlags().BoolP("no-color", "", false, "Disable color output")
Expand All @@ -88,9 +102,8 @@ func init() {
pterm.DisableStyling()
}

// Check if this command requires authentication
// Skip auth check for root command (help) and commands that don't need it
if cmd == rootCmd || cmd.Name() == "login" || cmd.Name() == "logout" || cmd.Name() == "auth" {
// Skip auth check for commands that don't need it (including children, e.g., "completion zsh")
if isAuthExempt(cmd) {
return nil
}

Expand Down