Skip to content

Conversation

@sjmiller609
Copy link
Contributor

@sjmiller609 sjmiller609 commented Oct 3, 2025

TL;DR

Add protocol support to the proxies command

Why we made these changes

This change allows users to create, list, view, and delete HTTP proxy configurations directly from the command line. This is the first step in enabling browser invocations to use managed HTTP proxies, which is critical for avoiding bot detection.

What changed?

  • proxies create: Creates a new proxy configuration. Now supports --protocol flag
  • proxies list: Lists all existing proxy configurations in a table. Now shows protocol

Validation

  • All new commands were manually tested against the API.
  • Unit tests covering the new functionality have been added and are passing.

Description generated by Mesa. Update settings

Copy link

@mesa-dot-dev mesa-dot-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Performed full review of c1e1cc6...2e24ad2

Analysis

  1. Default Protocol Value Inconsistency: Empty protocol values in CLI input don't set the params.Protocol parameter, creating a mismatch between what the API receives (unset/zero value) and what the CLI displays (showing "https" as default).

  2. API Parameter Mapping Gap: The create function lacks explicit handling to set params.Protocol to HTTPS when in.Protocol is empty, potentially causing the backend API to receive different protocol settings than what the CLI interface suggests to users.

  3. Potential Zero Value Risk: Without explicit default setting, the system might fall back to unexpected behavior when protocol parameters remain unset, creating potential confusion for API consumers.

Tip

⚡ Quick Actions

This review was generated by Mesa.

Actions:

Slash Commands:

  • /review - Request a full code review
  • /review latest - Review only changes since the last review
  • /describe - Generate PR description. This will update the PR body or issue comment depending on your configuration
  • /help - Get help with Mesa commands and configuration options

9 files reviewed | 0 comments | Review on Mesa | Edit Reviewer Settings

@sjmiller609 sjmiller609 merged commit c9601be into main Oct 3, 2025
2 checks passed
@sjmiller609 sjmiller609 deleted the http-proxy branch October 3, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants