Skip to content

feat add viewport 1200X800 #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mateoCuervo merged 2 commits into from
Nov 13, 2025
Merged

feat add viewport 1200X800 #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f522e0
update browsers.go and browsers_test.go
mateoCuervo Nov 13, 2025
69357e8
update browsers_test.go
mateoCuervo Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion cmd/browsers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@ func getAvailableViewports() []string {
"1920x1200@25",
"1440x900@25",
"1024x768@60",
"1200x800@60",
}
}

Expand Down Expand Up @@ -2013,7 +2014,7 @@ func init() {
browsersCreateCmd.Flags().Bool("save-changes", false, "If set, save changes back to the profile when the session ends")
browsersCreateCmd.Flags().String("proxy-id", "", "Proxy ID to use for the browser session")
browsersCreateCmd.Flags().StringSlice("extension", []string{}, "Extension IDs or names to load (repeatable; may be passed multiple times or comma-separated)")
browsersCreateCmd.Flags().String("viewport", "", "Browser viewport size (e.g., 1920x1080@25). Supported: 2560x1440@10, 1920x1080@25, 1920x1200@25, 1440x900@25, 1024x768@60")
browsersCreateCmd.Flags().String("viewport", "", "Browser viewport size (e.g., 1920x1080@25). Supported: 2560x1440@10, 1920x1080@25, 1920x1200@25, 1440x900@25, 1024x768@60, 1200x800@60")
browsersCreateCmd.Flags().Bool("viewport-interactive", false, "Interactively select viewport size from list")

// Add flags for delete command
Expand Down
3 changes: 2 additions & 1 deletion cmd/browsers_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1079,11 +1079,12 @@ func TestParseViewport_InvalidFormats(t *testing.T) {

func TestGetAvailableViewports_ReturnsExpectedOptions(t *testing.T) {
viewports := getAvailableViewports()
assert.Len(t, viewports, 5)
assert.Len(t, viewports, 6)
assert.Contains(t, viewports, "2560x1440@10")
assert.Contains(t, viewports, "1920x1080@25")
assert.Contains(t, viewports, "1920x1200@25")
assert.Contains(t, viewports, "1440x900@25")
assert.Contains(t, viewports, "1200x800@60")
assert.Contains(t, viewports, "1024x768@60")
}

Expand Down