feat(browsers): add Pool column to browsers list #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shows 'Pooled' when a browser session was acquired from a pool. Uses ExtraFields to detect pool_id until SDK is updated with the field.
![tembo[bot]](https://avatars.githubusercontent.com/in/1223475?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
|
|
||
| for _, browser := range browsers { | ||
| // log the browser | ||
| pterm.Info.Println(browser) |
There was a problem hiding this comment.
Debug logging accidentally left in production code
Debug logging statement pterm.Info.Println(browser) was accidentally left in the code. This will print the raw browser object to the terminal for every browser in the list, cluttering the output and confusing users. The comment "log the browser" confirms this was temporary debugging code that should have been removed before committing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Surfaces pool information in CLI outputs and plumbs
PoolIDthrough session helpers.Poolcolumn and logs eachbrowseritem; populates column frombrowser.PoolIDprintBrowserSessionResultandbuildBrowserTableDatanow acceptpoolIDand append"Pool ID"row when presentbrowsers get: base table now includesPool ID(when available)Written by Cursor Bugbot for commit badd948. This will update automatically on new commits. Configure here.