Skip to content

Conversation

@heyglassy
Copy link
Contributor

@heyglassy heyglassy commented Aug 14, 2025

Description

Please provide an explanation of the changes you've made:

Implementation Checklist

  • Implemented this change in TypeScript
  • Implemented this change in Python

Testing

  • All tests pass locally
  • Linted
  • Added tests for new functionality (if applicable)

Docs

  • Link to a PR in our docs repo documenting your change (if applicable)

Visual Proof

Please provide a screenshot or video demonstrating that your changes work locally:

Related Issue

Fixes [Github issue link]

Additional Notes


TL;DR

Updated all sample applications and CLI instructions to use kernel login for authentication instead of manually setting KERNEL_API_KEY environment variables.

Why we made these changes

To simplify and standardize the user authentication process, making it more user-friendly and consistent across all Kernel sample applications and documentation. This centralizes API key management and improves the developer experience.

What changed?

  • README.md: Updated API key setup instructions to suggest kernel login and improved general markdown formatting.
  • Core CLI Instructions (index.ts): Refactored string literals and conditional statements; updated printNextSteps to guide users towards kernel login.
  • Python Templates (templates/python/*/*.py): Modified main.py files in advanced-sample, cua, and sample-app to remove direct KERNEL_API_KEY environment variable usage, directing users to kernel login.
  • TypeScript Templates (templates/typescript/*/*.ts): Updated index.ts files in advanced-sample, cua, and sample-app comments and CLI invocation instructions to reflect the kernel login command. sample-app also received extensive code reformatting and consistent use of double quotes for strings.

Description generated by Mesa. Update settings

@heyglassy heyglassy requested a review from masnwilliams August 14, 2025 20:28
Copy link

@mesa-dot-dev mesa-dot-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Performed full review of 801f79f...bbe6c23

7 files reviewed | 0 comments | Review on Mesa | Edit Reviewer Settings

Copy link
Contributor

@masnwilliams masnwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so on our docs, we moved to kernel login but kept the api key route as a note, is there a good way to do that so people know its still an option?

heres what im referencing: https://docs.onkernel.com/quickstart#3-authenticate-with-kernel

Copy link
Contributor

@masnwilliams masnwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

cursor[bot]

This comment was marked as outdated.

@heyglassy heyglassy merged commit 46fb6f3 into main Aug 18, 2025
5 checks passed
@heyglassy heyglassy deleted the christian/change_to_kernel_login branch August 18, 2025 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants