Merged
Conversation
2f85ccc to
e9209ef
Compare
e9209ef to
34e94a0
Compare
34e94a0 to
a5af878
Compare
| var validationRegistry = map[reflect.Type][]validationEntry{} | ||
|
|
||
| func RegisterFieldValidator[T any, V string | bool | int](fieldName string, values ...V) { | ||
| func RegisterFieldValidator[T any, V string | bool | int | float64](fieldName string, values ...V) { |
There was a problem hiding this comment.
Bug: Float64 validator type added but implementation missing handling
The RegisterFieldValidator function's type constraint was expanded to accept float64 values, but the switch statement handling the values only has cases for []string, []int, and []bool. There's no case []float64 to handle float64 values, and the validationEntry.legalValues struct lacks a corresponding floats field. If someone uses RegisterFieldValidator with float64 values, the code compiles successfully but the values are silently ignored, resulting in no validation being applied for that field.
Additional Locations (1)
a5af878 to
23b708d
Compare
23b708d to
9bc8dc4
Compare
9bc8dc4 to
898261d
Compare
898261d to
5a4c4ce
Compare
5a4c4ce to
076f35c
Compare
rgarcia
approved these changes
Dec 23, 2025
Contributor
Author
|
🤖 Release is at https://github.com/onkernel/hypeman-go/releases/tag/v0.8.0 🌻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated Release PR
0.8.0 (2025-12-23)
Full Changelog: v0.7.0...v0.8.0
Features
Bug Fixes
Chores
This pull request is managed by Stainless's GitHub App.
The semver version number is based on included commit messages. Alternatively, you can manually set the version number in the title of this pull request.
For a better experience, it is recommended to use either rebase-merge or squash-merge when merging this pull request.
🔗 Stainless website
📚 Read the docs
🙋 Reach out for help or questions
Note
Release v0.8.0
DeviceServicewithNew/Get/List/Delete/ListAvailableendpoints, exposesclient.Devices, and introducesDevice,AvailableDevice, andDeviceTypemodelsInstances.Stat(GET /instances/{id}/stat) returningPathInfo;InstanceNewParamsnow supportsdevicesfor GPU/PCI passthroughfloat64; updates version refs,README.md,api.md, andCHANGELOG.mdWritten by Cursor Bugbot for commit 076f35c. This will update automatically on new commits. Configure here.