Skip to content

Conversation

@tembo
Copy link

@tembo tembo bot commented Nov 26, 2025

Description

Fixes 'exec' OpenAPI spec to match WebSocket implementation.

Changes

openapi.yaml updated ExecRequest schema and /exec endpoint for WebSocket protocol. Generated code updated.


Want me to make any changes? Add a review or comment with @tembo and i'll get back to work!

tembo.io slack.com app.tembo.io

@github-actions
Copy link

github-actions bot commented Nov 26, 2025

✱ Stainless preview builds

This PR will update the hypeman SDKs with the following commit message.

fix(openapi): Update exec spec

Edit this comment to update it. It will appear in the SDK's changelogs.

hypeman-go studio · code · diff

Your SDK built successfully.
generate ⚠️lint ✅test ✅

go get github.com/stainless-sdks/hypeman-go@bcca27670ce5536b4d0ade5140f28a49e551c9b8
hypeman-cli studio · code · diff

generate ⚠️lint ✅test ⏳

⏳ These are partial results; builds are still running.


This comment is auto-generated by GitHub Actions and is automatically kept up to date as you push.
Last updated: 2025-11-26 15:51:28 UTC

@mesa-dot-dev
Copy link

mesa-dot-dev bot commented Nov 26, 2025

Mesa Description

Description

Fixes 'exec' OpenAPI spec to match WebSocket implementation.

Changes

openapi.yaml updated ExecRequest schema and /exec endpoint for WebSocket protocol. Generated code updated.


Want me to make any changes? Add a review or comment with @tembo and i'll get back to work!

tembo.io slack.com app.tembo.io

Description generated by Mesa. Update settings

@sjmiller609 sjmiller609 deleted the tembo/hypeman-exec-openapi-spec-fix branch November 26, 2025 15:51
Copy link

@mesa-dot-dev mesa-dot-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Performed full review of db26f38...5d7d0b8

Analysis

  1. Breaking API Change: The PR changes the tty field default value from true to false, which will break existing API clients relying on the previous behavior. This needs proper documentation and migration guidance.

  2. Non-Portable Hardcoded Paths: Multiple files contain hardcoded absolute paths to a temporary workspace directory (/workspace/repo-76e8dc9d-020e-4ec1-93c2-ad0a593aa1a6), which will fail in other environments and break CI/CD pipelines.

  3. Repository Clutter: The PR adds 10+ temporary files (documentation, scripts, test files) that should be removed before merging to maintain repository hygiene.

  4. Stainless SDK Generation Failure: The SDK generation is currently failing with fatal errors that need investigation and resolution before merging.

  5. Lack of Schema Validation: The new fields (env, cwd, timeout) lack proper validation constraints that would improve API robustness.

Tip

Help

Slash Commands:

  • /review - Request a full code review
  • /review latest - Review only changes since the last review
  • /describe - Generate PR description. This will update the PR body or issue comment depending on your configuration
  • /help - Get help with Mesa commands and configuration options

12 files reviewed | 0 comments | Edit Agent SettingsRead Docs

Copy link

@mesa-dot-dev mesa-dot-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Performed full review of db26f38...5d7d0b8

Analysis

  1. Temporary File Pollution - Multiple development artifacts (regenerate.sh, run_build.go, run_make.py, test_compile.go, markdown files) should not be committed to the repository.

  2. Hardcoded Paths - Scripts contain environment-specific workspace paths that should be removed from version control.

  3. Manual Code Generation Risk - The generated file lib/oapi/oapi.go was manually edited rather than properly regenerated, potentially causing inconsistencies with the OpenAPI specification.

  4. Generated Code Synchronization Needed - The PR should run 'make oapi-generate' to ensure full synchronization between specification and generated code.

Tip

Help

Slash Commands:

  • /review - Request a full code review
  • /review latest - Review only changes since the last review
  • /describe - Generate PR description. This will update the PR body or issue comment depending on your configuration
  • /help - Get help with Mesa commands and configuration options

12 files reviewed | 0 comments | Edit Agent SettingsRead Docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant