-
Notifications
You must be signed in to change notification settings - Fork 1
fix(openapi): Update exec spec #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✱ Stainless preview buildsThis PR will update the Edit this comment to update it. It will appear in the SDK's changelogs. ✅ hypeman-go studio · code · diff
⏳ These are partial results; builds are still running. This comment is auto-generated by GitHub Actions and is automatically kept up to date as you push. |
Mesa DescriptionDescriptionFixes 'exec' OpenAPI spec to match WebSocket implementation. Changes
Description generated by Mesa. Update settings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Performed full review of db26f38...5d7d0b8
Analysis
-
Breaking API Change: The PR changes the
ttyfield default value fromtruetofalse, which will break existing API clients relying on the previous behavior. This needs proper documentation and migration guidance. -
Non-Portable Hardcoded Paths: Multiple files contain hardcoded absolute paths to a temporary workspace directory (
/workspace/repo-76e8dc9d-020e-4ec1-93c2-ad0a593aa1a6), which will fail in other environments and break CI/CD pipelines. -
Repository Clutter: The PR adds 10+ temporary files (documentation, scripts, test files) that should be removed before merging to maintain repository hygiene.
-
Stainless SDK Generation Failure: The SDK generation is currently failing with fatal errors that need investigation and resolution before merging.
-
Lack of Schema Validation: The new fields (
env,cwd,timeout) lack proper validation constraints that would improve API robustness.
Tip
Help
Slash Commands:
/review- Request a full code review/review latest- Review only changes since the last review/describe- Generate PR description. This will update the PR body or issue comment depending on your configuration/help- Get help with Mesa commands and configuration options
12 files reviewed | 0 comments | Edit Agent Settings • Read Docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Performed full review of db26f38...5d7d0b8
Analysis
-
Temporary File Pollution - Multiple development artifacts (regenerate.sh, run_build.go, run_make.py, test_compile.go, markdown files) should not be committed to the repository.
-
Hardcoded Paths - Scripts contain environment-specific workspace paths that should be removed from version control.
-
Manual Code Generation Risk - The generated file lib/oapi/oapi.go was manually edited rather than properly regenerated, potentially causing inconsistencies with the OpenAPI specification.
-
Generated Code Synchronization Needed - The PR should run 'make oapi-generate' to ensure full synchronization between specification and generated code.
Tip
Help
Slash Commands:
/review- Request a full code review/review latest- Review only changes since the last review/describe- Generate PR description. This will update the PR body or issue comment depending on your configuration/help- Get help with Mesa commands and configuration options
12 files reviewed | 0 comments | Edit Agent Settings • Read Docs
Description
Fixes 'exec' OpenAPI spec to match WebSocket implementation.
Changes
openapi.yamlupdatedExecRequestschema and/execendpoint for WebSocket protocol. Generated code updated.