Operational logs over API: hypeman.log, vmm.log #34

sjmiller609 · 2025-12-10T18:55:43Z

Note

Introduce per-instance hypeman and VMM logs with API streaming (app/vmm/hypeman), resource-resolving middleware, and updated logging/ingress/network behaviors.

Logging & Paths:
- Add per-instance operational log logs/hypeman.log and consolidate VMM output to logs/vmm.log; rename serial log to logs/app.log.
- Implement InstanceLogHandler to auto-route logs with instance_id to hypeman.log; wire into global logger.
- Rotate all three logs in RotateLogs.
API & Middleware:
- Add ResolveResource middleware; handlers now consume resolved instance/volume/ingress/image from context and simplify error paths.
- Update /instances/{id}/logs to support source query (app|vmm|hypeman) and return specific errors (tail missing, log not found).
- WebSocket exec handler uses resolved instance and enriched logging.
Instances:
- Stream logs by source; adjust create/start/stop/standby/restore/delete to use consistent instance_id logging and new log paths.
- Expose ingress-compatible resolver and minor state/list/query logging tweaks.
Ingress:
- Validate/resolve instances by name/ID; log ingress create/delete with ingress_id and target instance_id for per-instance audit logs.
Network:
- Safer TAP cleanup: preserve devices for running/unknown instances; allow skipping on errors.
VMM:
- Start process writes combined stdout+stderr to logs/vmm.log; tests updated accordingly.
OpenAPI/Client:
- Extend spec and generated client with source param for log streaming and updated docs.
Server wiring & Tests:
- Inject logger before access logging; enable resolver middleware for all routes; add context helpers in tests and refactor polling via managers.

^{Written by Cursor Bugbot for commit 228f6b1. This will update automatically on new commits. Configure here.}

github-actions · 2025-12-10T18:56:05Z

✱ Stainless preview builds

This PR will update the hypeman SDKs with the following commit message.

feat: Operational logs over API: hypeman.log, vmm.log

✅ hypeman-go studio · code

Your SDK built successfully.
generate ✅ → lint ✅ → test ✅
go get github.com/stainless-sdks/hypeman-go@ec614f5bdc0e110f31cec905d6deb7f1d460305b

⚡ hypeman-cli studio · conflict

There was a conflict between your custom code and your generated changes.
You don't need to resolve this conflict right now, but you will need to resolve it for your changes to be released to your users. Read more about why this happened here.

This comment is auto-generated by GitHub Actions and is automatically kept up to date as you push.
Last updated: 2025-12-11 03:02:40 UTC

lib/logger/instance_handler.go

lib/instances/logs.go

cmd/api/api/exec.go

cmd/api/main.go

lib/providers/providers.go

1. Exec endpoint now has logger injection: 2. Simplified InstanceLogHandler - no more file caching: - Removed `sharedState` struct with mutex and fileCache - Each write now opens, writes, closes the file - No cleanup methods needed = no leak possible - Simpler code, no shared state complexity The performance impact is negligible since instance operations (start, stop, standby, etc.) are infrequent. The tradeoff of slightly more I/O vs. guaranteed no leaks and simpler code is worth it.

sjmiller609 · 2025-12-10T19:42:15Z

cmd/api/main.go

+	// Get instance IDs that might have a running VMM for TAP cleanup safety.
+	// Include Unknown state: we couldn't confirm their state, but they might still
+	// have a running VMM. Better to leave a stale TAP than crash a running VM.
+	allInstances, _ := app.InstanceManager.ListInstances(app.Ctx)
+	var preserveTAPs []string
+	for _, inst := range allInstances {
+		if inst.State == instances.StateRunning || inst.State == instances.StateUnknown {
+			preserveTAPs = append(preserveTAPs, inst.Id)
+		}
+	}


This change is the fix for stopping a possibly running instance, the rest of the change is VMM and Hypeman logs feature, which was inspired by how this problem was debugged (find issue in CH logs)

cmd/api/api/exec.go

cmd/api/main.go

lib/logger/instance_handler.go

cmd/api/main.go

lib/logger/instance_handler.go

…top-prematurely

cmd/api/api/resolvers.go

1. Fixed `ErrAmbiguousName` to return 409 Conflict (instead of 404) Changed the HTTP status code from `http.StatusNotFound` to `http.StatusConflict` for ambiguous name errors, restoring the previous ingress behavior. 2. Added nil checks with 500 error responses for all `GetResolved*` calls Added defensive nil checks to all 14 handlers that use the resolved resource from middleware. If the middleware didn't set the resource (which shouldn't happen in production but could in tests), the handler now returns a 500 error with `"resource not resolved"` message instead of panicking with a nil pointer dereference.

$ hypeman ingress create q --hostname 'nginx-test' --port 80 --host-port 8081 Creating ingress nginx-test-wmbi... e5hbxzwc6cq0tnjchw861exg $ hypeman ingress list ID NAME HOSTNAME TARGET TLS CREATED e5hbxzwc6cq0 nginx-test-wmbi nginx-test nginx-gi7w:80 no 4 seconds ago Fix is shows "nginx-gi7w:80" instead of "g:80"

rgarcia · 2025-12-11T00:07:05Z

openapi.yaml

+          required: false
+          schema:
+            type: string
+            enum: [app, vmm, hypeman]


at first i thought maybe this endpoint should let you select more than one of these sources but i think for simplicity's sake it's fine to push this problem to clients to perform separate requests to get more than one source

rgarcia · 2025-12-11T00:09:52Z

lib/instances/logs.go

+		logPath = m.paths.InstanceHypemanLog(id)
+	default:
+		// Default to app log for backwards compatibility
+		logPath = m.paths.InstanceAppLog(id)


enjoy the freedom of not having to care about backwards compatability right now! :)

cursor bot reviewed Dec 10, 2025

View reviewed changes

lib/logger/instance_handler.go Show resolved Hide resolved

lib/instances/logs.go Show resolved Hide resolved

cmd/api/api/exec.go Show resolved Hide resolved

sjmiller609 added 2 commits December 10, 2025 14:04

Operational logs over API: hypeman.log, vmm.log

ac6bd97

Fix test

713620e

sjmiller609 force-pushed the fix-stop-prematurely branch from 2169a4d to 713620e Compare December 10, 2025 19:09

sjmiller609 added 2 commits December 10, 2025 14:14

Review instance log handler

f2525b7

Use log not found error

5c32875

cursor bot reviewed Dec 10, 2025

View reviewed changes

cmd/api/main.go Show resolved Hide resolved

lib/providers/providers.go Show resolved Hide resolved

sjmiller609 added 2 commits December 10, 2025 14:36

Don't delete taps when instance state is unknown

3dd1f9d

sjmiller609 commented Dec 10, 2025

View reviewed changes

add logs

6af82cc

cursor bot reviewed Dec 10, 2025

View reviewed changes

cmd/api/api/exec.go Outdated Show resolved Hide resolved

Fix which id

c92b545

sjmiller609 requested a review from rgarcia December 10, 2025 20:00

cursor bot reviewed Dec 10, 2025

View reviewed changes

cmd/api/main.go Outdated Show resolved Hide resolved

lib/logger/instance_handler.go Show resolved Hide resolved

Reivew fixes

db6c89f

cursor bot reviewed Dec 10, 2025

View reviewed changes

cmd/api/main.go Show resolved Hide resolved

sjmiller609 added 2 commits December 10, 2025 15:26

run cleanup when no vm

390d6c6

Merge branch 'main' into fix-stop-prematurely

92b2854

cursor bot reviewed Dec 10, 2025

View reviewed changes

lib/logger/instance_handler.go Show resolved Hide resolved

sjmiller609 added 2 commits December 10, 2025 16:29

Move resource id, partial id, name resolution to middleware

b6c7c37

Merge remote-tracking branch 'origin/fix-stop-prematurely' into fix-s…

dada46d

…top-prematurely

cursor bot reviewed Dec 10, 2025

View reviewed changes

cmd/api/api/resolvers.go Show resolved Hide resolved

sjmiller609 added 3 commits December 10, 2025 17:17

Fix response code

dfddd92

rgarcia approved these changes Dec 11, 2025

View reviewed changes

sjmiller609 merged commit a076e43 into main Dec 11, 2025
4 checks passed

sjmiller609 deleted the fix-stop-prematurely branch December 11, 2025 03:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Operational logs over API: hypeman.log, vmm.log #34

Operational logs over API: hypeman.log, vmm.log #34

Uh oh!

sjmiller609 commented Dec 10, 2025 •

edited by cursor bot

Loading

Uh oh!

github-actions bot commented Dec 10, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sjmiller609 Dec 10, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rgarcia Dec 11, 2025

Uh oh!

rgarcia Dec 11, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Operational logs over API: hypeman.log, vmm.log #34

Operational logs over API: hypeman.log, vmm.log #34

Uh oh!

Conversation

sjmiller609 commented Dec 10, 2025 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✱ Stainless preview builds

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sjmiller609 Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rgarcia Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

rgarcia Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sjmiller609 commented Dec 10, 2025 •

edited by cursor bot

Loading

github-actions bot commented Dec 10, 2025 •

edited

Loading