Oci manifest platform mismatch #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gests Co-authored-by: raf <[email protected]>
|
Cursor Agent can help with this pull request. Just |
rgarcia
added a commit
that referenced
this pull request
Dec 23, 2025
* feat: add arm64/aarch64 multi-arch support Add support for arm64 architecture: - Map arm64 to aarch64 in GetArch() for kernel/binary paths - Map arm64 to aarch64 in cloud-hypervisor binary extraction - Add platform-specific OCI image pulling with remote.WithPlatform() to correctly pull the right architecture for multi-arch images - Add golang/protobuf dependency for grpc compatibility * Refactor inspectManifest to use remote.Image for platform-specific digests (#46) Co-authored-by: Cursor Agent <[email protected]> --------- Co-authored-by: Cursor Agent <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Align
inspectManifest's digest retrieval withpullToOCILayoutto ensure consistent platform-specific digests for multi-arch images.Previously,
inspectManifestreturned the manifest index digest for multi-arch images, whilepullToOCILayoutfetched the platform-specific image. This discrepancy caused cache keys to not match the actual pulled content, leading to cache misses and incorrect cache behavior. The change ensures both functions retrieve the same platform-specific digest.Note
Ensures digest discovery matches the actual pulled content for multi-arch images, preventing cache key mismatches.
inspectManifestnow usesremote.Image(..., WithPlatform(currentPlatform()))andimg.Digest()to resolve the platform-specific manifest digestremote.Head(which returned the manifest index digest) and adds clarifying commentsWritten by Cursor Bugbot for commit 9fd3bb4. This will update automatically on new commits. Configure here.