Merged
Conversation
![tembo[bot]](https://avatars.githubusercontent.com/in/1223475?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
sjmiller609
force-pushed
the
qemu-capabilities
branch
from
f49ce4d to
3afbd74
Compare
sjmiller609
commented
Dec 23, 2025
rgarcia
approved these changes
Dec 23, 2025
| // QEMU uses migrate to file for snapshots | ||
| // The "file:" protocol is deprecated in QEMU 7.2+, use "exec:cat > path" instead | ||
| memoryFile := destPath + "/memory" | ||
| uri := "exec:cat > " + memoryFile |
There was a problem hiding this comment.
Shell command paths not escaped for spaces/metacharacters
The QEMU exec: migration protocol runs commands through /bin/sh -c, but the file paths in uri := "exec:cat > " + memoryFile and incomingURI := "exec:cat < " + memoryFile are not quoted or escaped. If the data directory path contains spaces or shell metacharacters (e.g., /home/user/My Data/hypeman), the shell will misparse the command, causing snapshot and restore operations to fail silently or produce unexpected behavior.
Additional Locations (1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Adds end-to-end QEMU standby/restore support and refines process/QMP handling, plus observability improvements.
Standby/Restoreusing QMP migrate-to-file; savesqemu-config.jsonon start and loads it for restore; starts QEMU with-incoming exec:cat < memoryand waits for VM readinessWaitMigration,WaitVMReady),Migrate, and tuned timeouts/polling; exposes status and raw commandsstartQEMUProcesswith socket readiness checks, log redirection, cleanup handling, and debug timings; constants for dial/wait intervalsSupportsSnapshotnow true for QEMUTestQEMUStandbyAndRestorecovering snapshot/restore path; extends QEMU E2E helpersWritten by Cursor Bugbot for commit c998b64. This will update automatically on new commits. Configure here.