Fix stop / start instance with network #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjmiller609
commented
Jan 21, 2026
sjmiller609
force-pushed
the
fix-start-instance-with-network
branch
from
fb8412e to
cbf891d
Compare
hiroTamada
approved these changes
Jan 21, 2026
Contributor
hiroTamada
left a comment
hiroTamada
left a comment
There was a problem hiding this comment.
clean fix for the stop/start name collision issue. excluding the instance from its own uniqueness check is the right approach.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Enables stop/start of instances with networking by refining name-uniqueness checks and aligning tests with network initialization.
Managerinterface and implementation:NameExists(ctx, name, excludeInstanceID); skips the provided instance ID during checksCreateAllocationto use the new signature so restarts don't conflict with the instance’s own nameBridgeName,SubnetCIDR,DNSServer) and callsNetworkManager.Initialize(...);ApiServiceincludesNetworkManagernetwork.enabled=trueto cover stop/start with networkingWritten by Cursor Bugbot for commit cbf891d. This will update automatically on new commits. Configure here.