Skip to content

fix: disable scale-to-zero when process is spawned #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rgarcia merged 3 commits into from
Dec 8, 2025
Merged

fix: disable scale-to-zero when process is spawned #102

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
42b6d77
fix: disable scale-to-zero when process is spawned
rgarcia Dec 7, 2025
b3fc9ab
fix: only call Enable() if Disable() succeeded
rgarcia Dec 7, 2025
bdb981c
fix: initialize stz in process tests with NoopController
rgarcia Dec 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion server/cmd/api/api/process.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,11 @@ func (s *ApiService) ProcessSpawn(ctx context.Context, request oapi.ProcessSpawn
return oapi.ProcessSpawn500JSONResponse{InternalErrorJSONResponse: oapi.InternalErrorJSONResponse{Message: "failed to start process"}}, nil
}

// Disable scale-to-zero while the process is running
if err := s.stz.Disable(ctx); err != nil {
log.Error("failed to disable scale-to-zero", "err", err)
}

id := openapi_types.UUID(uuid.New())
h := &processHandle{
id: id,
Expand Down Expand Up @@ -294,7 +299,9 @@ func (s *ApiService) ProcessSpawn(ctx context.Context, request oapi.ProcessSpawn
}
}()

// Waiter goroutine
// Waiter goroutine - use context without cancel since HTTP request may complete
// before the process exits
stzCtx := context.WithoutCancel(ctx)
go func() {
err := cmd.Wait()
code := 0
Expand All @@ -310,6 +317,12 @@ func (s *ApiService) ProcessSpawn(ctx context.Context, request oapi.ProcessSpawn
}
}
h.setExited(code)

// Re-enable scale-to-zero now that the process has exited
if err := s.stz.Enable(stzCtx); err != nil {
log.Error("failed to enable scale-to-zero", "err", err)
}

// Send exit event
evt := oapi.ProcessStreamEventEvent("exit")
h.outCh <- oapi.ProcessStreamEvent{Event: &evt, ExitCode: &code}
Expand Down
Loading