Skip to content

Clean up logs #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sayan- merged 1 commit into from
Dec 23, 2025
Merged

Clean up logs #111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions server/cmd/api/api/computer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,8 +350,6 @@ func (s *ApiService) TypeText(ctx context.Context, request oapi.TypeTextRequestO
// Use "--" to terminate options and pass raw text
args = append(args, "--", body.Text)

log.Info("executing xdotool", "args", args)

output, err := defaultXdoTool.Run(ctx, args...)
if err != nil {
log.Error("xdotool command failed", "err", err, "output", string(output))
Expand Down Expand Up @@ -465,7 +463,6 @@ func (s *ApiService) PressKey(ctx context.Context, request oapi.PressKeyRequestO
argsDown = append(argsDown, "keydown", key)
}

log.Info("executing xdotool (keydown phase)", "args", argsDown)
if output, err := defaultXdoTool.Run(ctx, argsDown...); err != nil {
log.Error("xdotool keydown failed", "err", err, "output", string(output))
// Best-effort release any keys that may be down (primary and modifiers)
Expand Down Expand Up @@ -497,7 +494,6 @@ func (s *ApiService) PressKey(ctx context.Context, request oapi.PressKeyRequestO
}
}

log.Info("executing xdotool (keyup phase)", "args", argsUp)
if output, err := defaultXdoTool.Run(ctx, argsUp...); err != nil {
log.Error("xdotool keyup failed", "err", err, "output", string(output))
return oapi.PressKey500JSONResponse{InternalErrorJSONResponse: oapi.InternalErrorJSONResponse{
Expand All @@ -524,7 +520,6 @@ func (s *ApiService) PressKey(ctx context.Context, request oapi.PressKeyRequestO
}
}

log.Info("executing xdotool", "args", args)
output, err := defaultXdoTool.Run(ctx, args...)
if err != nil {
log.Error("xdotool command failed", "err", err, "output", string(output))
Expand Down
4 changes: 2 additions & 2 deletions server/cmd/api/api/playwright.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ func (s *ApiService) ExecutePlaywrightCode(ctx context.Context, request oapi.Exe
}, nil
}

log.Error("playwright execution failed", "error", err, "output", string(output))
log.Error("playwright execution failed", "error", err)

// Try to parse the error output as JSON
var result struct {
Expand Down Expand Up @@ -117,7 +117,7 @@ func (s *ApiService) ExecutePlaywrightCode(ctx context.Context, request oapi.Exe
Result interface{} `json:"result,omitempty"`
}
if err := json.Unmarshal(output, &result); err != nil {
log.Error("failed to parse playwright output", "error", err, "output", string(output))
log.Error("failed to parse playwright output", "error", err)
success := false
errorMsg := fmt.Sprintf("failed to parse output: %v", err)
stdout := string(output)
Expand Down
Loading