Skip to content

Fix docker build failure when buildkit container is absent #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sayan- merged 3 commits into from
Jul 8, 2025
Merged

Fix docker build failure when buildkit container is absent #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
94f95a8
fix(docker): container presence check failure, extra output
matthewjmarangoni Jul 7, 2025
53fb79d
Apply suggestion from @Sayan- fixing exit when container is stopped
matthewjmarangoni Jul 8, 2025
95ece89
Apply suggestion from @Sayan- propagating conversion of test to if co…
matthewjmarangoni Jul 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion images/chromium-headful/build-docker.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/usr/bin/env bash
set -ex -o pipefail
set -e -o pipefail

# Move to the script's directory so relative paths work regardless of the caller CWD
SCRIPT_DIR=$(cd "$(dirname "$0")" && pwd)
Expand Down
10 changes: 4 additions & 6 deletions shared/start-buildkit.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,20 +6,18 @@
export KRAFTKIT_BUILDKIT_HOST=docker-container://buildkit

# Install container if not already installed.
docker container inspect buildkit > /dev/null 2>&1
if test $? -eq 0; then
if [ -n "$(docker ps --all --no-trunc --quiet --filter 'name=^buildkit$')" ]; then
echo "Container 'buildkit' is already installed. Nothing to do."
else
echo "Installing 'buildkit' container ... "
docker run -d --name buildkit --privileged moby/buildkit:latest
return $?
fi

test "$(docker container inspect -f '{{.State.Running}}' buildkit 2> /dev/null)" = "true"
if test $? -eq 0; then
echo "Container 'buidlkitd' is already running. Nothing to do."
if [ "$(docker container inspect -f '{{.State.Running}}' buildkit 2> /dev/null)" = "true" ]; then
echo "Container 'buildkit' is already running. Nothing to do."
else
echo "Starting 'buildkit' container ... "
docker start buildkit
return $?
fi
fi
Loading