Block scale to zero during recording, allow multiple recordings #29
BugBot Review
BugBot Analysis Progress (9m 44s elapsed)
✅ Gathered PR context (20s)
✅ Analyzed code changes (26s)
✅ Completed bug detection — 1 potential bug found (8m 55s)
✅ Validation and filtering completed (0s)
✅ Posted analysis results — 1 bug reported (3s)
✅ Analysis completed successfully (0s)
Final Result: BugBot completed review and found 1 potential issue
Request ID: serverGenReqId_bb540472-bb50-48ee-b0c9-07966962cfcd
Details
Bug: Recorder List Method Misnamed
The FFmpegManager.ListActiveRecorders method is misnamed. It returns all registered recorders instead of only active (currently recording) ones, as its name implies. This is a regression, as the previous implementation correctly filtered for active recorders using IsRecording(). This mismatch between the method's name and its behavior breaks its implied contract and can lead to developer confusion.
server/lib/recorder/ffmpeg.go#L424-L434
Was this report helpful? Give feedback by reacting with 👍 or 👎