Skip to content

Conversation

@rgarcia
Copy link
Contributor

@rgarcia rgarcia commented Oct 31, 2025

before:

image

after:

image

also applied the same policy file to the headless image. Tested this with a vibed up playwright script that connected to the headless image and took a screenshot of coupang.com


Note

Adds CJK/emoji fonts and shared Chromium managed policy (disabling translate/autofill/password manager) to both headful and headless images.

  • Docker images:
    • Headful (images/chromium-headful/Dockerfile):
      • Install fontconfig, fonts-noto-cjk, fonts-noto-color-emoji, fonts-nanum; run fc-cache -f; minor cleanup with apt-get clean.
      • Copy shared Chromium managed policy to /etc/chromium/policies/managed/policy.json.
    • Headless (images/chromium-headless/image/Dockerfile):
      • Install fontconfig, fonts-noto-cjk, fonts-noto-color-emoji, fonts-nanum; run fc-cache -f.
      • Copy shared Chromium managed policy to /etc/chromium/policies/managed/policy.json.
  • Chromium policies:
    • Add shared/chromium-policies/managed/policy.json with PasswordManagerEnabled, AutofillCreditCardEnabled, and TranslateEnabled set to false.
    • Remove legacy image-chromium/etc/chromium/policies/managed/autofill.json.

Written by Cursor Bugbot for commit f8b915f. This will update automatically on new commits. Configure here.

@rgarcia rgarcia requested a review from hiroTamada October 31, 2025 18:06
@mesa-dot-dev
Copy link

mesa-dot-dev bot commented Oct 31, 2025

Mesa Description

before:

image

after:

image

also applied the same policy file to the headless image. Tested this with a vibed up playwright script that connected to the headless image and took a screenshot of coupang.com


This PR fixes an issue where non-English characters were not rendering correctly and disables Chromium's translation popup.

These changes are applied to both the chromium-headful and chromium-headless images to ensure consistent behavior.

  • Font Installation: Added CJK, emoji, and Nanum font packages to both Dockerfiles to ensure proper character rendering.
  • Shared Chromium Policies:
    • Created a new shared policy at shared/chromium-policies/managed/policy.json to disable the password manager, credit card autofill, and the translation service.
    • Removed the old, duplicated autofill.json policy.
  • Image Updates: Both headful and headless Dockerfiles were updated to install the new fonts and copy the shared policy file.

Description generated by Mesa. Update settings

Copy link
Contributor

@hiroTamada hiroTamada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there is a conflict. But LGTM

Copy link

@mesa-dot-dev mesa-dot-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Performed full review of e928eb1...bc7eb93

Analysis

  1. No clear validation strategy for ensuring the centralized policy.json remains consistent and backward compatible when modified
  2. Potential performance impact from adding comprehensive font support to both headful and headless images, which may increase image size and memory footprint
  3. Lacks details on error handling or fallback mechanisms if font cache refresh after installation fails
  4. No mention of compatibility testing across different operating systems/environments to ensure consistent font rendering

Tip

Help

Configure your agents

Mesa Docs

Slash Commands:

  • /review - Request a full code review
  • /review latest - Review only changes since the last review
  • /describe - Generate PR description. This will update the PR body or issue comment depending on your configuration
  • /help - Get help with Mesa commands and configuration options

4 files reviewed | 0 comments | Edit Agent Settings

@rgarcia rgarcia merged commit b51da91 into main Oct 31, 2025
6 checks passed
@rgarcia rgarcia deleted the raf/kernel-469-ranger-coupangcom-live-view-missing-non-english-characters branch October 31, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants