-
Notifications
You must be signed in to change notification settings - Fork 0
release: 0.8.3 #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release: 0.8.3 #35
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What Changed
This automated pull request handles the version bump to 0.8.3. The primary change in this release is a small internal cleanup, which removes a redundant imports configuration from the package.json file. The CHANGELOG.md and other version-related files have also been updated accordingly.
Risks / Concerns
This is a low-risk, automated release. The only change is a minor internal improvement. Great work keeping the codebase clean!
5 files reviewed | 0 comments | Review on Mesa | Edit Reviewer Settings
0fae477 to
743b241
Compare
78527ef to
743b241
Compare
|
🧪 Testing To try out this version of the SDK, run: Expires: Sun, 31 Aug 2025 19:26:40 GMT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What Changed
This pull request prepares for a new release, v0.9.0. The most significant change is the reduction of the default API client timeout from 60 seconds to 5 seconds in src/client.ts. The PR also includes an internal cleanup, removing a redundant imports configuration from package.json.
Risks / Concerns
The primary risk is the significant reduction of the default request timeout from 60 seconds to 5 seconds. As highlighted in the review, this is a potentially breaking change for users who rely on the previous default for long-running operations and could lead to unexpected timeouts in their applications. The PR title release: 0.8.3 also conflicts with the feat commit and the version bump to 0.9.0 in package.json, suggesting a mismatch in how the impact of this change was classified.
4 files reviewed | 1 comments | Review on Mesa | Edit Reviewer Settings
src/client.ts
Outdated
|
|
||
| static Kernel = this; | ||
| static DEFAULT_TIMEOUT = 60000; // 1 minute | ||
| static DEFAULT_TIMEOUT = 5000; // 5 seconds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a significant behavioral change that reduces the default timeout by 92% (from 60s to 5s). This could potentially break existing applications that rely on operations taking longer than 5 seconds. Consider if this should be documented as a breaking change rather than a patch release, especially since users who haven't explicitly set a timeout will suddenly experience much shorter timeouts.
Type: Logic | Severity: Medium
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What Changed
This is an automated release PR for version 0.9.0. The main change introduced is the reduction of the default API client timeout from 60 seconds to 5 seconds, as updated in src/client.ts. This change has been documented in the README.md. Additionally, a redundant imports configuration was removed from package.json as part of internal housekeeping.
Risks / Concerns
The reduction of the default timeout from 60 seconds to 5 seconds is a significant behavioral change. Consumers updating to this version might experience unexpected timeouts on operations that previously succeeded, requiring them to explicitly configure a longer timeout if needed.
4 files reviewed | 0 comments | Review on Mesa | Edit Reviewer Settings
Release version edited manuallyThe Pull Request version has been manually set to If you instead want to use the version number |
60fa2a2 to
743b241
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What Changed
This pull request automates the release of version 0.9.0 of the SDK. It bundles two main updates:
- Timeout Reduction: A feature change that lowers the default client request timeout from 60 seconds to 5 seconds in
src/client.ts. TheREADME.mdhas been updated to reflect this new default. - Internal Cleanup: A chore that removes a redundant
importsconfiguration frompackage.json, improving project maintainability.
Consequently, CHANGELOG.md, package.json, and src/version.ts have all been updated to reflect the new 0.9.0 version.
Risks / Concerns
The primary risk is the significant reduction of the default timeout from 60s to 5s. This could be a breaking change for clients who were implicitly relying on the longer timeout for slow operations, potentially causing unexpected request failures after updating.
7 files reviewed | 0 comments | Review on Mesa | Edit Reviewer Settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What Changed
This is an automated pull request to release version 0.9.0. The primary feature introduced is a reduction of the default API client timeout from 60 seconds to 5 seconds, as implemented in src/client.ts. This update is also reflected in the README.md. The release also includes a minor internal cleanup, removing a redundant imports configuration from package.json.
Risks / Concerns
The changes are straightforward and well-documented in the changelog. The most significant change is the reduction of the default request timeout from 60 seconds to 5 seconds. While this is flagged as a new feature, consumers of the library should be aware of this change as it could affect operations that previously relied on the longer default.
7 files reviewed | 0 comments | Review on Mesa | Edit Reviewer Settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What Changed
This automated PR releases version 0.8.3. The primary change is a reduction of the default API request timeout from 60 seconds to 5 seconds in src/client.ts. The README.md has been updated to reflect this new default. Additionally, a redundant imports configuration was removed from package.json.
Risks / Concerns
The changes are clear and well-scoped. The only point of concern is that reducing the default timeout from 60s to 5s could be a breaking change for consumers relying on the previous, longer default for certain operations. Given this introduces a new default behavior, it might be more appropriate as a minor version bump rather than a patch release to better signal the potential impact to users.
4 files reviewed | 0 comments | Review on Mesa | Edit Reviewer Settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What Changed
This is an automated release PR for version 0.8.3. The main feature is a reduction of the default API client timeout from 60 seconds to 5 seconds, updated in src/client.ts and reflected in the README.md and CHANGELOG.md. Additionally, a redundant imports configuration was removed from package.json as part of internal code cleanup.
Risks / Concerns
The primary risk, as highlighted in the review, is that reducing the default request timeout from 60 seconds to 5 seconds is a significant behavioral change. This could be a breaking change for existing integrations that rely on the longer timeout for certain operations, potentially causing unexpected failures upon upgrade.
7 files reviewed | 1 comments | Review on Mesa | Edit Reviewer Settings
21cb97b to
d341269
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What Changed
This is an automated release PR bumping the package version to 0.8.3. The main functional change is lowering the default API request timeout to 5 seconds. The release also includes an internal chore to remove a redundant imports configuration from package.json.
Risks / Concerns
The key change in this release is lowering the default API timeout to 5 seconds, as noted in commit 743b241. While this is intended as a feature, it could be a breaking change for users who rely on longer-running requests and have not explicitly configured a higher timeout. This might lead to unexpected timeouts in existing integrations.
2 files reviewed | 0 comments | Review on Mesa | Edit Reviewer Settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What Changed
This automated release PR bumps the package version to 0.8.3. The main changes include reducing the default API timeout from 60 seconds to 5 seconds and removing a redundant imports configuration from package.json.
Risks / Concerns
The reduction of the default request timeout from 60s to 5s is a significant behavioral change. While categorized as a feature, it could be a breaking change for users relying on the previous longer timeout for certain operations, potentially causing unexpected timeouts in their applications.
5 files reviewed | 1 comments | Review on Mesa | Edit Reviewer Settings
|
|
||
| ### Features | ||
|
|
||
| * **api:** lower default timeout to 5s ([743b241](https://github.com/onkernel/kernel-node-sdk/commit/743b24161f294e289a6fe17537d02b8fe35f7b06)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The timeout reduction from 60s to 5s (a 92% decrease) is categorized as a "Feature" but this is a significant behavioral change that could break existing applications. Consider categorizing this as a breaking change or at minimum adding a note about the potential impact, as users reading the changelog may not realize the severity of this change.
Type: Logic | Severity: Medium
|
🤖 Release is at https://github.com/onkernel/kernel-node-sdk/releases/tag/v0.8.3 🌻 |
Automated Release PR
0.8.3 (2025-08-01)
Full Changelog: v0.8.2...v0.8.3
Features
Chores
This pull request is managed by Stainless's GitHub App.
The semver version number is based on included commit messages. Alternatively, you can manually set the version number in the title of this pull request.
For a better experience, it is recommended to use either rebase-merge or squash-merge when merging this pull request.
🔗 Stainless website
📚 Read the docs
🙋 Reach out for help or questions