prevent users from using Kernel with Bun #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mesa-dot-dev[bot]](https://avatars.githubusercontent.com/in/1050077?s=60&v=4){kind=small}
There was a problem hiding this comment.
Performed full review of 3fd6a3e...89985e3
1 files reviewed | 0 comments | Review on Mesa | Edit Reviewer Settings
rgarcia
reviewed
Aug 12, 2025
| ) { | ||
| throw new Errors.KernelError('The Bun runtime is not supported. Please use a different runtime.'); | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
The problem is the combination of Bun and Playwright, right? If so I think we should be more forgiving and log a warning to that effect (instead of throwing) and also give users the option to turn off the warning, e.g.
"WARNING: if you are using Playwright with Bun you will not be able to connect over CDP: {link to GitHub issue}.
Turn off this warning with KERNEL_BUN_WARNING=off"
rgarcia
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Disables the
Kernelclient from running in the Bun JavaScript runtime.Why we made these changes
To prevent
Kernelfrom being used in an unsupported or incompatible environment, avoiding potential issues or undefined behavior.What changed?
src/client.ts: Modified theKernelclient constructor to include a runtime check that throws aKernelErrorif Bun is detected as the current runtime.Description generated by Mesa. Update settings