Merged
Conversation
Member
|
Please read the contributing guideline here looks like black is complaining about format issue |
Contributor
|
This is great. Thanks for the contribution. Beyond the format issue, I'd also add a mention about the new arg option in the documentation. |
Adds --arch to results options and parameter filter_architecture to api params in dashboard_fetch_summary, dashboard_fetch_builds, dashboard_fetch_boots, and dashboard_fetch_tests. Signed-off-by: Camila Alvarez <cam.alvarez.i@gmail.com>
CamilaAlvarez
force-pushed
the
results-arch-filter
branch
from
eddc48c to
f322f0c
Compare
Signed-off-by: Camila Alvarez <cam.alvarez.i@gmail.com>
Contributor
Author
|
Hello @aliceinwire @padovan! I fixed the format and added the option to the documentation |
Member
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds --arch to results options and parameter filter_architecture to api params in dashboard_fetch_summary, dashboard_fetch_builds, dashboard_fetch_boots, and dashboard_fetch_tests.