src/{send_kcidb,logspec_api}: report unclean boot as PASS#972
Merged
nuclearcat merged 3 commits intokernelci:mainfrom Jan 28, 2025
Merged
src/{send_kcidb,logspec_api}: report unclean boot as PASS#972nuclearcat merged 3 commits intokernelci:mainfrom
nuclearcat merged 3 commits intokernelci:mainfrom
Conversation
added 2 commits
January 22, 2025 15:08
If the kernel booted, but maestro had set that to FAIL, change it to PASS and create an issue with WARNING. Signed-off-by: Helen Koike <helen.koike@collabora.com>
If nothing was submited, return True to indicate we had no errors on the submission. Signed-off-by: Helen Koike <helen.koike@collabora.com>
install latest logspec Signed-off-by: Helen Koike <helen.koike@collabora.com>
nuclearcat
approved these changes
Jan 28, 2025
Member
nuclearcat
left a comment
nuclearcat
left a comment
There was a problem hiding this comment.
Looks fine on staging, merging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the kernel booted, but maestro had set that to FAIL, change it to
PASS and create an issue with WARNING.