test: fix test collection failure when clang is not installed#245
Merged
bhcopeland merged 2 commits intokernelci:masterfrom Feb 10, 2026
Merged
test: fix test collection failure when clang is not installed#245bhcopeland merged 2 commits intokernelci:masterfrom
bhcopeland merged 2 commits intokernelci:masterfrom
Conversation
The clang_version variable was evaluated at module level during test collection which causes a FileNotFoundError when clang is not available. This broke the deb and rpm package builds in CI since those containers dont have clang installed. Replace the subprocess call with a simple shutil.which check, same pattern as the existing lld check on the same test. The clang 10 version check is not needed anymore since clang 10 is from 2020. Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
roxell
force-pushed
the
fix-test-collection-failure
branch
from
d26b3a9 to
86605b6
Compare
Drop the custom release script and the duplicated packaging targets from the Makefile. Use tuxpkg instead which handles all of this already. The old release script had flit publish between tag and push --tags which caused a half done state when flit failed. tuxpkg does the release in a safer order (commit, tag, push, push --tags) and lets CI handle the pypi upload. Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
roxell
force-pushed
the
fix-test-collection-failure
branch
from
1f4175c to
542b617
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The clang_version variable was evaluated at module level during test collection which causes a FileNotFoundError when clang is not available. This broke the deb and rpm package builds in CI since those containers dont have clang installed.
Replace the subprocess call with a simple shutil.which check, same pattern as the existing lld check on the same test. The clang 10 version check is not needed anymore since clang 10 is from 2020.