Skip to content

Document process about upgrade buildroot and kernel#1049

Merged
troglobit merged 1 commit intomainfrom
document-kernel-buildroot-update
Jul 11, 2025
Merged

Document process about upgrade buildroot and kernel#1049
troglobit merged 1 commit intomainfrom
document-kernel-buildroot-update

Conversation

@mattiaswal
Copy link
Contributor

[skip ci]

Description

Checklist

Tick relevant boxes, this PR is-a or has-a:

  • Bugfix
    • Regression tests
    • ChangeLog updates (for next release)
  • Feature
    • YANG model change => revision updated?
    • Regression tests added?
    • ChangeLog updates (for next release)
    • Documentation added?
  • Test changes
    • Checked in changed Readme.adoc (make test-spec)
    • Added new test to group Readme.adoc and yaml file
  • Code style update (formatting, renaming)
  • Refactoring (please detail in commit messages)
  • Build related changes
  • Documentation content changes
    • ChangeLog updated (for major changes)
  • Other (please describe):

@mattiaswal mattiaswal requested review from jovatn and troglobit May 19, 2025 12:06
@mattiaswal mattiaswal force-pushed the document-kernel-buildroot-update branch from d93c48f to e08b702 Compare May 19, 2025 12:10
Copy link
Contributor

@jovatn jovatn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! But someone more skilled should also have a look.

Some minor comments and questions included.

Comment on lines 222 to 223
branches should contain **only** changes to existing packages (but no
new patches), modifications to Buildroot itself or upstream backports.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably obvious to those who understand, but to me it is not clear what "(but no new patches)" means. E.g., is it the "new" that is important, and "old patches" are ok?
And should "(but no new patches)" be put at the end of the sentence, or does it only apply to "existing packages"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always a case by case, new is a (strict) guideline :D

@mattiaswal mattiaswal force-pushed the document-kernel-buildroot-update branch from e08b702 to 5f01a50 Compare May 27, 2025 07:24
@mattiaswal mattiaswal requested review from axkar and jovatn May 27, 2025 07:24
Copy link
Collaborator

@axkar axkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 🥇

Copy link
Contributor

@troglobit troglobit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor stylistic and formatting related comments only. Other than that, great work!

@mattiaswal mattiaswal force-pushed the document-kernel-buildroot-update branch from 5f01a50 to eabaaac Compare June 19, 2025 13:48
@mattiaswal mattiaswal requested a review from troglobit June 19, 2025 13:48
Copy link
Contributor

@troglobit troglobit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it, nice work on this! (Sorry for dragging my feet.)

@troglobit troglobit merged commit 692fa16 into main Jul 11, 2025
5 checks passed
@troglobit troglobit deleted the document-kernel-buildroot-update branch July 11, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants