Merged
Conversation
Update description to match new option name: subnet -> netmask. Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
There was a problem hiding this comment.
Pull Request Overview
Add support for Raspberry Pi 4B by introducing a new BoardBuild configuration, U-Boot overlays and scripts, and updating documentation.
- New aarch64 Buildroot defconfig and post-build scripts for RPi4B
- Extended U-Boot pre-build to bundle device-tree overlays
- Documentation updates: ChangeLog and README
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| configs/rpi4_defconfig | Add Buildroot defconfig for Raspberry Pi 4B |
| board/common/uboot/uboot.mk | Extend U-Boot pre-build to generate and include overlays |
| board/aarch64/rpi/uboot/rpi-env.dtso | New U-Boot environment overlay for RPi4B |
| doc/ChangeLog.md | Document addition of Raspberry Pi 4B support |
| README.md | List Raspberry Pi 4B in supported boards |
Comments suppressed due to low confidence (1)
configs/rpi4_defconfig:1
- Consider adding regression or integration tests to validate the Raspberry Pi 4B build configuration and ensure continued CI coverage for this new board.
BR2_aarch64=y
- switch to 6.12 LTS, same as other Infix boards - trim down kernel config a bit - sync defconfig with r2s to switch to Finit Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Apparently the BCM2835 watchdog driver does not hook into /dev/watchdog but creates its own /dev/watchdog0, and is very picky about interval and timeout as well it seems. Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Also, fix placement of the VisionFive2, it's not an Aarch64 boartd. Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for the popular Raspberry Pi 4B.
Checklist
Tick relevant boxes, this PR is-a or has-a: