Skip to content

Fix warnings from Coverity Scan#1087

Merged
troglobit merged 3 commits intomainfrom
cleanup
Aug 11, 2025
Merged

Fix warnings from Coverity Scan#1087
troglobit merged 3 commits intomainfrom
cleanup

Conversation

@troglobit
Copy link
Contributor

Description

This PR contains minor cleanups and fixups to issues indentified by Coverity Scan.

Checklist

Tick relevant boxes, this PR is-a or has-a:

  • Bugfix
    • Regression tests
    • ChangeLog updates (for next release)
  • Feature
    • YANG model change => revision updated?
    • Regression tests added?
    • ChangeLog updates (for next release)
    • Documentation added?
  • Test changes
    • Checked in changed Readme.adoc (make test-spec)
    • Added new test to group Readme.adoc and yaml file
  • Code style update (formatting, renaming)
  • Refactoring (please detail in commit messages)
  • Build related changes
  • Documentation content changes
    • ChangeLog updated (for major changes)
  • Other (please describe):

The execd runner has not been used since Nov, 2024, ca0e54b.  This
weekend it started triggering a warning from Coverity Scan, so let
us drop it for good this time.

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Found by Coverity Scan

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Copilot AI review requested due to automatic review settings August 4, 2025 06:09
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the execd component from the codebase to address issues identified by Coverity Scan. The change completely eliminates a job queue executor that was designed to retry network-dependent tasks on route changes.

  • Complete removal of the execd daemon and its associated build/packaging files
  • Removal of execd from the host build configuration
  • Cleanup of package configuration references

Reviewed Changes

Copilot reviewed 16 out of 18 changed files in this pull request and generated no comments.

File Description
src/execd/* Complete removal of execd source code, build files, and documentation
package/execd/* Removal of all packaging configuration and service files
src/Makefile Updated to exclude execd from host build apps list
package/Config.in Removed execd package configuration reference

@troglobit troglobit requested a review from mattiaswal August 4, 2025 07:34
Copy link
Contributor

@mattiaswal mattiaswal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@troglobit troglobit merged commit 14dd7cb into main Aug 11, 2025
5 checks passed
@troglobit troglobit deleted the cleanup branch August 11, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants