Skip to content

Conversation

@mattiaswal
Copy link
Contributor

@mattiaswal mattiaswal commented Sep 16, 2025

This fix #1137

Description

Checklist

Tick relevant boxes, this PR is-a or has-a:

  • Bugfix
    • Regression tests
    • ChangeLog updates (for next release)
  • Feature
    • YANG model change => revision updated?
    • Regression tests added?
    • ChangeLog updates (for next release)
    • Documentation added?
  • Test changes
    • Checked in changed Readme.adoc (make test-spec)
    • Added new test to group Readme.adoc and yaml file
  • Code style update (formatting, renaming)
  • Refactoring (please detail in commit messages)
  • Build related changes
  • Documentation content changes
    • ChangeLog updated (for major changes)
  • Other (please describe):

@mattiaswal mattiaswal added the ci:main Build default defconfig, not minimal label Sep 16, 2025
Copy link
Contributor

@troglobit troglobit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice (hard) work on this 💪 and the tests pass (of course) 🎉 so I'm approving this.

As an added bonus, it looks like this upgrade greatly reduces the patch overhead in our tree as well?

Minor nitpick, maybe we should mention the Rousette (RESTCONF) upgrade as well. It is an official external interface, after all, that is enabled by default. I leave it up to you. If you want to add it, just do add a [skip ci] in the commit message to prevent re-build/test of the branch and merge it! 😃👍

@wkz
Copy link
Contributor

wkz commented Sep 17, 2025

Gotta love that +2.5k/-25k 👀 💪

@mattiaswal mattiaswal merged commit 2f13fc7 into main Sep 17, 2025
6 checks passed
@mattiaswal mattiaswal deleted the upgrade-sysrepo branch September 17, 2025 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:main Build default defconfig, not minimal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade netopeer2 and rousette

4 participants