-
Notifications
You must be signed in to change notification settings - Fork 14
Rauc integration fixes #1164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rauc integration fixes #1164
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes RAUC integration issues by updating the install-bundle RPC to use the newer D-Bus method and adds two new optional arguments for controlling certificate and compatibility verification. It also replaces ANSI color-coded console event logging with a dedicated JSON event log.
- Replace deprecated
rauc_installer_call_install_syncwithrauc_installer_call_install_bundle_sync - Add optional
verify-certificateandverify-compatibleparameters to install-bundle RPC - Switch from console logging to JSON event logging for better log management
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/confd/yang/confd/infix-system-software.yang | Add YANG model definitions for new optional parameters |
| src/confd/src/infix-system-software.c | Implement parameter parsing and updated RAUC D-Bus method call |
| doc/ChangeLog.md | Document the fix for issue #1080 |
| board/*/rootfs/etc/rauc/system.conf | Add JSON event log configuration across all board types |
| board/common/rootfs/etc/finit.d/available/rauc.conf | Remove console logging redirection |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Fixes #1080 Signed-off-by: Joachim Wiberg <[email protected]>
The rauc event logger is a separate glib logger that by default logs to the system console, with annoying ANSI escape sequences. This commit drops the default stdout/stderr redirect of these log messages and adds a more exhaustive bundle install and event log, in json format, instead. For more information about event logging, see the rauc documentation: https://rauc.readthedocs.io/en/latest/advanced.html Signed-off-by: Joachim Wiberg <[email protected]>
Signed-off-by: Joachim Wiberg <[email protected]>
5da16f7 to
6bd00d8
Compare
wkz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨
Description
install-bundleRPCverify-certificate— weather to verify bundle certificate at install, default:Trueverify-compatible— weather to verify if bundle is compatible, default:TrueChecklist
Tick relevant boxes, this PR is-a or has-a: