OSPF: skip interfaces without OSPF enabled #1170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a bug where systems with OSPF enabled on some, but not all,
interfaces would cause the OSPF iterator to fail when accessing
iface['area'], which was missing. This caused the ospf_status.py
tool to return {}, resulting in empty OSPF data in sysrepo.
Fixes #1169 Expected neighbors not shown in sysrepocfg
Signed-off-by: Richard Alpe <[email protected]>
troglobit
approved these changes
Sep 30, 2025
Contributor
troglobit
left a comment
troglobit
left a comment
There was a problem hiding this comment.
Nice and clean, not to mention obvious. We like it when bugs are shallow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug where systems with OSPF enabled on some, but not all, interfaces would cause the OSPF iterator to fail when accessing iface['area'], which was missing. This caused the ospf_status.py tool to return {}, resulting in empty OSPF data in sysrepo.
Fixes #1169 Expected neighbors not shown in sysrepocfg
Description
Checklist
Tick relevant boxes, this PR is-a or has-a: