Conversation
Prevent patch releases from stealing the "latest" tag from newer minor versions. Only vXX.YY and vXX.YY.0 releases should be marked as latest. Fixes #1187 Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
This is a backport of the following commits from origin/main: 3b24fab e6a04fb 92e80b4 ad96965 3e03ece 21256a8 b7d91e4 d26e311 0977ab4 f83fbc6 --- cli: fix 'copy FILE running-config' use-case When copying to the running datastore we cannot use sr_copy_config(), instead we must use sr_replace_config(). This fix covers both the case of 'copy startup-config running-config' and 'copy FILE running-config'. Fixes #1203 --- cli: add 'validate', or '-n', dry run to copy command This commit adds config file validation to the copy command, discussed in #373. Allowing users to test their config files before restoring a backup. The feature could also be used for the automatic rollback when downgrading to an earlier version of the OS. Fixes #373 --- cli: fix copy to missing startup-config file Fixes #981 --- cli: restrict copy and erase commands This is a follow-up to PR #717 where path traversal protection was discussed. A year later and it's clear that having a user-friendly copy tool in the shell is a good thing, but that we proably want to restrict what it can do when called from the CLI. A sanitize flag (-s) is added to control the behavior, when used in the shell without -s, both commands act like traditional UNIX tools and do assume . for relative paths, and allow ../, whereas when running from the CLI only /media/ is allowed and otherwise files are assumed to be in $HOME or /cfg --- cli: sanitize regular file to file copy The regular file-to-file copy, was missing calls to cfg_adjust(), this commit fixes that and adds some helpful comments for each use-case. Also, drop insecure mktemp() in favor of our own version which uses the basename of the remote source file. --- bin: add bash completion for copy command Add bash completion for the common datastores, like we already do in the CLI, and update the usage text accordingly. Also, make sure to install to /usr/bin, not /bin since we've now merged the hierarchies since a while back. --- bin: copy: Refactor copy() made some...creative...use of control flow that made it quite difficult to follow. Take a first priciples approach to simplify the logic. --- bin: copy: Always get startup from sysrepo This will make sure to apply NACM rules for all the data. It also makes it possible for a luser access a subset of the data, even if they to do not have read access to /cfg/startup-config.cfg. Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Backported from origin/main 5420fb0 Includes the latest DRAM ECC status, with/without sudo, and temperature. Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Dec 8 15:22:44 ix-00-00-00 watchdogd[2599]: Memory usage: 195036 kB, cached: 69740 kB, total: 423628 kB Dec 8 15:22:44 ix-00-00-00 watchdogd[2599]: File system /var usage: blocks 4710/52564 inodes 80/65456 Dec 8 15:22:44 ix-00-00-00 watchdogd[2599]: File descriptor usage: 640/34603 Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Turn on OOPS-to-panic, soft/hard lockup panic, hung-task panic, and extra workqueue watchdog reporting. This makes latent stalls visible instead of silently freezing, improving diagnosis of issues like the recent resource-pressure lockup. Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Usable by all Server Base System Architecture (SBSA) compliant SoCs, e.g., CN9130.
This will be us the ability to test a hardware watchdog's ability to trigger on different kinds of lockups.
Contributor
Author
|
When PR #1329 has been merged to main we can lift in that kernel bump on this branch as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Proposed fixes to backport to v25.08.2:
Fixes to annoying issues with critical CLI copy command
copy startup running#1203copy#1213Motivation: significantly cuts down on customer support issues with saving configuration changes, making backups, or restoring.
Disable hard-coded OSFP debug config, add configuration support
Motivation: Infix v25.08.1 has all OSPF debug messages hard-coded
ospfd) has memory leaksBackport support script, new after v25.11.0, with additional logs not in v25.08.x:
Motivation: useful for any future problems, reduces customer friction when collecting logs
Enable kernel panic on lockups + hung tasks => console log + reboot
Enable watchdogd resource monitors, logs: memory/file system+descriptor use
Motivation: out of memory, full disk, and file "descriptor" exhaustion are by far the most common software issues. This backport simplifies monitoring these resources.
Enable CN9130 HW watchdog
Checklist
Tick relevant boxes, this PR is-a or has-a: