fix: day-week-in-month-date-time-between-failures#12809
fix: day-week-in-month-date-time-between-failures#12809hemantmm wants to merge 19 commits intokestra-io:developfrom
Conversation
|
@loicmathieu, can you review this PR? |
core/src/main/java/io/kestra/plugin/core/condition/DateTimeBetween.java
Outdated
Show resolved
Hide resolved
|
Hey @hemantmm, thank you very much for you contribution. Could you rebase your PR with the Also, could you please reevaluate the changes you've made on the Thanks a lot. |
Signed-off-by: Hemant M Mehta <hemant29mehta@gmail.com>
Signed-off-by: Hemant M Mehta <hemant29mehta@gmail.com>
Signed-off-by: Hemant M Mehta <hemant29mehta@gmail.com>
…hen conditions fail Signed-off-by: Hemant M Mehta <hemant29mehta@gmail.com>
Signed-off-by: Hemant M Mehta <hemant29mehta@gmail.com>
Signed-off-by: Hemant M Mehta <hemant29mehta@gmail.com>
Signed-off-by: Hemant M Mehta <hemant29mehta@gmail.com>
Signed-off-by: Hemant M Mehta <hemant29mehta@gmail.com>
Signed-off-by: Hemant M Mehta <hemant29mehta@gmail.com>
8751683 to
0a6aa73
Compare
Signed-off-by: Hemant M Mehta <hemant29mehta@gmail.com>
|
@loicmathieu, can you review this PR? |
|
@hemantmm @fhussonnois will review it as he worked on this area lately |
|
@fhussonnois, can you review this PR? |
core/src/main/java/io/kestra/plugin/core/condition/DateTimeBetween.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/kestra/plugin/core/condition/DateTimeBetween.java
Outdated
Show resolved
Hide resolved
scheduler/src/test/java/io/kestra/scheduler/SchedulerConditionTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Hemant M Mehta <hemant29mehta@gmail.com>
|
@fhussonnois, can you review this PR? |
|
@Skraye will continue the review when he'll be back |
|
@Skraye, can you review this PR? |
|
@hemantmm Please resolve the merge conflict here. |
|
@hemantmm Can you make sure the project compile ? Thanks |
Signed-off-by: Hemant M Mehta <hemant29mehta@gmail.com>
…eekInMonth Signed-off-by: Hemant M Mehta <hemant29mehta@gmail.com>
|
@Skraye, now the project compiles. Can you have a look at it? |

closes: #8230
What changes are being made and why?
✅ Fixed dynamic property rendering for date in
DayWeekInMonthandDateTimeBetweenconditions.✅ Updated usage to
.render(date).as(String.class, vars).orElseThrow()for correct value extraction.✅ Ensured tests pass after migration from
String datetoProperty<String> date.Fix:
Updated the rendering logic for dynamic date properties in schedule conditions:
datefield fromStringtoProperty<String>in both classes.runContext.render(date, vars)torunContext.render(date).as(String.class, vars).orElseThrow().