Skip to content

fix(ui): add numbered pagination and row numbers to ION file preview.#14206

Open
BrajamohanDas-afk wants to merge 16 commits intokestra-io:developfrom
BrajamohanDas-afk:fix/ion-pagination-11886
Open

fix(ui): add numbered pagination and row numbers to ION file preview.#14206
BrajamohanDas-afk wants to merge 16 commits intokestra-io:developfrom
BrajamohanDas-afk:fix/ion-pagination-11886

Conversation

@BrajamohanDas-afk
Copy link
Contributor

✨ Description

Adds numbered pagination and row numbers to the ION file preview table.

  • Replaces custom pagination with Element Plus numbered pagination component
  • Adds a row number column showing actual file position
  • Increases backend fetch limits to 500 default / 5000 max
  • Adds pagination summary display ("Showing rows X-Y of Z")
  • Prevents UI freeze for large ION files

🔗 Related Issue

Closes #11886

🎨 Frontend Checklist

  • Code builds without errors (npm run build)
  • All existing E2E tests pass (npm run test:e2e)
  • Screenshots or video recordings attached showing the UI changes

📝 Additional Notes

  • Please see attached screen record for before/after comparison.
  • No backend code was changed.
Comparision.mp4

@github-project-automation github-project-automation bot moved this to To review in Pull Requests Jan 18, 2026
@MilosPaunovic MilosPaunovic self-requested a review January 20, 2026 07:46
@MilosPaunovic MilosPaunovic added area/frontend Needs frontend code changes kind/external Pull requests raised by community contributors labels Jan 20, 2026
@MilosPaunovic MilosPaunovic requested review from Piyush-r-bhaskar and removed request for MilosPaunovic January 27, 2026 12:16
@Piyush-r-bhaskar
Copy link
Contributor

Piyush-r-bhaskar commented Jan 27, 2026

@BrajamohanDas-afk could you share you flow used for testing this ?

nvm, I got this here #11886 (comment)

Copy link
Contributor

@Piyush-r-bhaskar Piyush-r-bhaskar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @BrajamohanDas-afk

Thanks for your PR.

Could you make use of a common Pagination component ui/src/components/layout/Pagination.vue in our repo to avoid multipe lines of code ?

@MilosPaunovic MilosPaunovic moved this from To review to On hold in Pull Requests Feb 2, 2026
@BrajamohanDas-afk
Copy link
Contributor Author

Yes, I will do that.

@MilosPaunovic MilosPaunovic moved this from On hold to To review in Pull Requests Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/frontend Needs frontend code changes kind/external Pull requests raised by community contributors

Projects

Status: To review

Development

Successfully merging this pull request may close these issues.

File output preview freezes UI for large ION files (with more than ~5000 rows)

3 participants