perf(utils): replace TreeMap with HashMap in MapUtils#14383
Open
MTarek165 wants to merge 2 commits intokestra-io:developfrom
Open
perf(utils): replace TreeMap with HashMap in MapUtils#14383MTarek165 wants to merge 2 commits intokestra-io:developfrom
MTarek165 wants to merge 2 commits intokestra-io:developfrom
Conversation
loicmathieu
reviewed
Feb 2, 2026
Member
loicmathieu
left a comment
There was a problem hiding this comment.
@fhussonnois did you remember if there was some rational to use a TreeMap here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
flattenToNestedMap() is on a critical path and is invoked at least twice per execution, even when no inputs, outputs, or labels are defined, and may also be triggered indirectly from other paths( like each time creating a new run context by adding execution labels), so for a non trivial executions it is called many times per execution.