Open
Conversation
MilosPaunovic
added
area/frontend
brian-mulier-p
force-pushed
the
add-kv-ui-tests
branch
from
fe9a2bf to
d00e266
Compare
Member
|
Hello @hemantmm, it looks AI generated or there is a missing piece as |
brian-mulier-p
requested changes
Feb 4, 2026
Member
brian-mulier-p
left a comment
brian-mulier-p
left a comment
There was a problem hiding this comment.
AI Generated or missing pieces
Contributor
Author
|
I appreciate your feedback 👍. I'll review the tests and UI selectors to make sure nothing is assumed or missing. Certain sections were swiftly scaffolded in and clearly require hardening to conform to the current user interface. I'll fix it and soon update the PR. |
Signed-off-by: Hemant M Mehta <hemant29mehta@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #12767
✨ Description
What does this PR change?
The new tests include creating, saving, editing, and validating KV entries for all supported types of KV, to ensure that the values are properly restored when reopening a KV for editing.
The UI tests include the following: