fix(ui): resolve back button redirect loop on execution pages#14412
Open
mohitjeswani01 wants to merge 20 commits intokestra-io:developfrom
Open
fix(ui): resolve back button redirect loop on execution pages#14412mohitjeswani01 wants to merge 20 commits intokestra-io:developfrom
mohitjeswani01 wants to merge 20 commits intokestra-io:developfrom
Conversation
Member
|
Can you resolve the merge conflict here @mohitjeswani01? |
Contributor
Author
|
Hi @MilosPaunovic, I have resolved the merge conflicts in routes.js |
Contributor
Author
|
hi @MilosPaunovic do i need to make any changes in this ? |
Member
|
Hi @mohitjeswani01, This pull request will be reviewed at our earliest convenience. Thanks for all the efforts so far! 🍀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Description
This PR resolves a navigation issue where users were trapped in a redirect loop when using the browser's Back button from an execution detail page.
Previously, navigating back would land users on an intermediate “untabbed” execution URL, which immediately redirected forward again — effectively trapping the user.
Key changes include:
onMountedhook to abeforeEnterguard inroutes.js.replace: trueduring the initial redirect so the base execution URL (without a tab) is overwritten in browser history, allowing a single Back click to return to the Execution List.useRouterimport inuseExecutionRoot.tsto satisfy ESLint.🔗 Related Issue
Closes #14285
🎨 Frontend Checklist
npm run build)npm run test:e2e)UIchanges(See attached
kestra_back_button_routefix.mp4)📝 Additional Notes
The fix was verified locally by checking the browser history stack.
Previously, the stack recorded an intermediate “untabbed” URL which triggered a forward redirect upon back-navigation. The new implementation ensures the history stack remains clean.
demo
kestra.button.fix.-.Made.with.Clipchamp.mp4